test: finish adapter validation (importer coverage + export conformance)#96
Open
sorenwacker wants to merge 1 commit into
Open
test: finish adapter validation (importer coverage + export conformance)#96sorenwacker wants to merge 1 commit into
sorenwacker wants to merge 1 commit into
Conversation
Add @network round-trip conformance tests so every exporter is validated, not just ENA: PRIDE submission.px structure (required MTD + FMH/FME), MetaboLights ISA-Tab sections + study/assay/MAF files, and the BrAPI v2 object shape via jsonschema (asserting the level stays nested in observationUnitPosition). Document that importers were exercised across diverse live accessions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the validation gap flagged in the review's honest status.
Importer coverage — exercised each importer against several diverse live accessions (ENA run/sample/study incl. a 495-file study; 4 PXD incl. a 2384-file project; 4 MTBLS with 1-9 people / 1-3 assays). No new mapping gaps surfaced — the review fixes hold on real data.
Export conformance — every exporter now has an
@networkround-trip conformance test, not just ENA:submission.pxstructure (required MTD lines + well-formed FMH/FME).The one remaining unknown is acceptance by the live submission endpoints (no export round-tripped through a real submission system yet). jsonschema added to dev; mkdocs --strict / ruff / mypy green.
🤖 Generated with Claude Code