Skip to content

[feature]: import SORA Icons #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: 514-csf-3
Choose a base branch
from
Draft

[feature]: import SORA Icons #535

wants to merge 3 commits into from

Conversation

@0x009922
Copy link
Contributor

@0x009922 0x009922 commented Mar 28, 2023 •
edited
Loading

I made some changes to icons I imported from Figma:

  • Removed fill color (it was set to some), set fill="currentColor"
  • Used adaptive width/height. Instead of width="24" and height="24" I set width="1em" and height="1em". Some icons had height=25&width=24, so I used adaptive width, i.e. height=1em & width={24 / 25}em.
  • Optimised and formatted all icons with SVGO: 
    svgo -f ./src/*/solid --pretty --indent 2

@0x009922 0x009922 added the next Related to next lib iteration, i.e. based on Vue 3 label Mar 28, 2023
Base automatically changed from 513-enable-eslint-rules to 514-csf-3 March 28, 2023 10:59
@0x009922 0x009922 mentioned this pull request Mar 28, 2023
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

next Related to next lib iteration, i.e. based on Vue 3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@0x009922