-
Notifications
You must be signed in to change notification settings - Fork 0
[CHORE/#26] 로그 레벨 설정 #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Summary by CodeRabbit릴리스 노트
✏️ Tip: You can customize this high-level summary in your review settings. Walkthrough새로운 로깅 설정 파일 Changes
Sequence Diagram(s)(생략 — 변경이 구성 파일 추가로, 다중 컴포넌트 제어 흐름 변경을 수반하지 않음) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 분 Suggested labels
Suggested reviewers
Poem
Pre-merge checks✅ Passed checks (5 passed)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/main/resources/logback.xml (1)
2-5: AWS SDK 하위 패키지 로거 설정의 중복 가능성logback의 로거 계층 구조에서
software.amazon.awssdk를 INFO로 설정하면 그 하위 패키지들(.request, .http, .core)도 자동으로 INFO 레벨을 상속받습니다. 명시적인 하위 패키지 설정은 의도를 명확히 하는 장점은 있지만, 유지보수 시 일관성 유지에 주의가 필요합니다.특정 하위 패키지만 다른 레벨로 설정할 계획이 없다면 2번 라인만 유지하는 것도 고려해보세요.
🔎 간소화된 설정 예시
<logger name="software.amazon.awssdk" level="INFO"/> - <logger name="software.amazon.awssdk.request" level="INFO"/> - <logger name="software.amazon.awssdk.http" level="INFO"/> - <logger name="software.amazon.awssdk.core" level="INFO"/>
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/resources/logback.xml
🔇 Additional comments (1)
src/main/resources/logback.xml (1)
7-7: 애플리케이션 로거 설정 적절함
com.sopt.push패키지를 DEBUG 레벨로 유지하여 디버깅 편의성을 확보한 설정이 PR 목적에 부합합니다.
Related Issue 🚀
Work Description ✏️
PR Point 📸