-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACL] Add support for COPY action #3288
Conversation
@bingwang-ms for viz |
@prsunny Could we please get it in 202405? Shall I raise a separate PR for it? |
What I did Added COPY packet action, that uses SAI_PACKET_ACTION_COPY attribute. Why I did it This allows ACL to copy packets to CPU. It can be used to dump and debug transit packets.
Cherry-pick PR to 202405: #3346 |
@developfast , @prsunny Sorry I missed the review of this PR. The only concern for this change is different capabilities on different platforms. Not sure if we have checked that? |
@bingwang-ms shall I update yang to add PACKET_ACTION enumeration of COPY? https://github.com/sonic-net/SONiC/blob/master/sonic-acl.yang#L138 |
Yes, the YANG model needs to be updated. |
What I did Added COPY packet action, that uses SAI_PACKET_ACTION_COPY attribute. Why I did it This allows ACL to copy packets to CPU. It can be used to dump and debug transit packets.
What I did
Added COPY packet action, that uses SAI_PACKET_ACTION_COPY attribute.
Why I did it
This allows ACL to copy packets to CPU. It can be used to dump and debug transit packets.
How I verified it
Install the ACL with COPY action and verify that packets are punted towards the CPU with matching criteria.
Details if related