Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[common] enable redispipeline to only publish after flush #895

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[common] enable redispipeline to only publish after flush #895

wants to merge 1 commit into from
+81 −23

Conversation

a114j0y
Copy link

@a114j0y a114j0y commented Jul 22, 2024 •
edited
Loading

What I did

  • optimize redispipeline flush performance by remove unnecessary publish commands
  • add a new parameterbool flushPub in producerstatetable constructor function
    • to enable/disable batch publish feature
    • default value of m_flushPub is false, so no impact on existing codes
    • optimization is effective only explicitly set this option
  • remove individual publish command from the producerstatetable APIs' lua scripts
  • add a publish command when the pipeline flushes [if m_flushPub is true]

Why I did it

  • save TCP traffic and increase fpmsyncd efficiency

It's a feature included in BGP Loading Optimization HLD #1521 GitHub issue/pull request detail

@a114j0y a114j0y mentioned this pull request Jul 22, 2024
Open
@a114j0y a114j0y force-pushed the flushpub branch 2 times, most recently from 81ee88f to 3ef9655 Compare August 25, 2024 23:31
liuh-80
liuh-80 reviewed Aug 26, 2024
View reviewed changes
common/Makefile.am Outdated Show resolved Hide resolved
@a114j0y a114j0y force-pushed the flushpub branch 6 times, most recently from 5c0a375 to d033f37 Compare August 30, 2024 21:57
@a114j0y a114j0y force-pushed the flushpub branch 3 times, most recently from fa5c60a to 4aa6ac6 Compare September 17, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuh-80 liuh-80 liuh-80 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a114j0y @liuh-80