Add helper function to validate interface name length #889
Conversation
|
@prsunny Can you help please reviewing this and the attached PRs? |
|
@prsunny , @qiluo-msft , Can you please approve this PR ? |
|
|
||
| size_t ifaceNameMaxLen() | ||
| { | ||
| return IFNAMSIZ; |
There was a problem hiding this comment.
@liuh-80 The purpose of this PR is to share a const to multiple applications in C++/python/go. What is the best practice? any sample?
There was a problem hiding this comment.
The best practice is to define a const variable, SWIG will generate a global read-only wrapper:
https://www.swig.org/Doc4.0/SWIGDocumentation.html#SWIG_nn13
I think the issue here is IFNAMESIZ is not defined in sonic-swss-common, it's defined in the libc.
So, the SWIG can't generate wrapper for it.
|
Do you still need this PR? if not, you can 'Close' it. |
I think it is good to have this PR in order to export IFNAMSIZ value for sonic-utilities config scripts, not? |
|
@arfeigin , a workaround could be define a new variable: |
|
@qiluo-msft @liuh-80 Please review #931 |
This PR is accompanied by sonic-net/sonic-buildimage#20108 and sonic-net/sonic-utilities#3397
Add helper function to validate that interface name length does not exceed allowed length configured as IFNAMSIZ. This will be used both by sonic-utilities CLI (config) and by cfgmgr.