Skip to content

Sketch 98 compatibility #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Sketch 98 compatibility #38

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73eaa90
Replace absoluteRect() calls with frame()
rodionovd Oct 9, 2023
1f467ea
Fix createImage(): avoid absoluteInfluenceRect() and update MSExporte…
rodionovd Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions Symbol Instance Locator.sketchplugin/Contents/Sketch/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,14 +106,14 @@ var locate = function(context) {

document.sketchObject.documentWindow().makeKeyAndOrderFront(null)
document.sketchObject.setCurrentPage(symbolMaster.sketchObject.parentPage())
document.sketchObject.contentDrawView().zoomToFitRect(symbolMaster.sketchObject.absoluteRect().rect())
document.sketchObject.contentDrawView().zoomToFitRect(symbolMaster.sketchObject.frame().rect())

symbolMaster.sketchObject.select_byExtendingSelection(1,0)
})
} else {
document.sketchObject.currentPage().changeSelectionBySelectingLayers(nil)
document.sketchObject.setCurrentPage(symbolMaster.sketchObject.parentPage())
document.sketchObject.contentDrawView().zoomToFitRect(symbolMaster.sketchObject.absoluteRect().rect())
document.sketchObject.contentDrawView().zoomToFitRect(symbolMaster.sketchObject.frame().rect())

symbolMaster.sketchObject.select_byExtendingSelection(1,0)
}
Expand Down Expand Up @@ -219,11 +219,11 @@ function createImage(instance,frame) {
image.setWantsLayer(1)
image.layer().setBackgroundColor(NSColor.controlBackgroundColor())

var exportRequest = MSExportRequest.exportRequestsFromExportableLayer_inRect_useIDForName_(
instance,
instance.absoluteInfluenceRect(),
false
).firstObject()
var exportRequest = MSExportRequest.exportRequestsFromLayerAncestry_(instance.ancestry()).firstObject()
var exporter = MSExporter.exporterForRequest_colorSpace_(exportRequest, null)
// This will make sure exportRequest.rect() is calculated correctly before we use it below
// See https://forum.sketch.com/t/absoluteinfluencerect-removed-in-sketch-96/1031/4
_= exporter.trimmedBounds()

exportRequest.format = 'png'

Expand All @@ -232,9 +232,7 @@ function createImage(instance,frame) {

exportRequest.scale = (scaleX < scaleY) ? scaleX : scaleY

var colorSpace = NSColorSpace.sRGBColorSpace()
var exporter = MSExporter.exporterForRequest_colorSpace_(exportRequest,colorSpace)
var imageRep = exporter.bitmapImageRep()
var imageRep = exporter.bitmapImageRepAndReturnError(null)
var instanceImage = NSImage.alloc().init().autorelease()

instanceImage.addRepresentation(imageRep)
Expand Down Expand Up @@ -286,7 +284,7 @@ function createTarget(instance,targets,frame) {
sender.layer().setBorderWidth(2)
sender.layer().setBorderColor(NSColor.controlAccentColor().CGColor())

var rect = (instance.parentArtboard()) ? instance.parentArtboard().rect() : instance.absoluteRect().rect()
var rect = (instance.parentArtboard()) ? instance.parentArtboard().rect() : instance.frame().rect()

document.sketchObject.documentWindow().makeKeyAndOrderFront(null)
document.sketchObject.setCurrentPage(instance.parentPage())
Expand Down