basic composer tests in CI#27
Conversation
|
this PR might fail, since current lockfile is wrong/outdated (probably caused by #21). |
bhamail
left a comment
There was a problem hiding this comment.
A question about my solution to the CI build failure.
| executor: << parameters.e >> | ||
| steps: | ||
| - checkout | ||
| - run: composer validate |
There was a problem hiding this comment.
I was able to get both build_and_test-1 and build_and_test-2 to succeed in local CI builds by removing the compose validate command. Also not sure if that is a good solution, and would like your thoughts.
There was a problem hiding this comment.
thanks for reviewing.
to succeed in local CI builds by removing the
compose validatecommand.
removing these lines would miss the point of this PR.
CI found errors, because things were broken, as intriduced by #21 (and fixed by #23)
after #23 got merged to "main" branch, i rebased this PR onto "main" branch. i expect CI tests to pass, now.
unfortunately CI tests were not running after the rebase.
@bhamail are you able to run CI tests in CircleCI manually?
There was a problem hiding this comment.
@jkowalleck Thanks so much for your explanations - it helps me get a clue!
I think I have successfully resolved the merge conflict and preserved your intention to validate things in the build - but please take a look to make sure I'm on track.
Trying to fix my mess after attempting to resolve merge conflicts. I think it just needs the goodies from main to be happy...however, I'm still seeing memory related failure (locally and in cloud build) in build_and_test-2 via:
circleci config process .circleci/config.yml > .circleci/local-config.yml && circleci local execute -c .circleci/local-config.yml --job 'build_and_test-2'
Here's the local error I'm seeing now:
====>> composer update
#!/bin/bash -eo pipefail
composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)
Fatal error: Allowed memory size of 1610612736 bytes exhausted (tried to allocate 4096 bytes) in phar:///usr/local/bin/composer/src/Composer/DependencyResolver/RuleWatchGraph.php on line 52
Check https://getcomposer.org/doc/articles/troubleshooting.md#memory-limit-errors for more info on how to handle out of memory errors.Error: Exited with code 255
Step failed
There was a problem hiding this comment.
I think I have successfully resolved the merge conflict [...]
what merge conflicts? there were no merge conflicts.
I rebased this branch onto "main" without any issues and pushed it to github. see #27 (comment)
i set this PR to be a draft, until things get sorted out.
|
@madpah Unless there is an objection from @jkowalleck, it may be best to create a new fork with the fixes. I tried re-running the CI builds from this PR, but it would not start. |
closes #26