Skip to content

basic composer tests in CI#27

Draft
jkowalleck wants to merge 2 commits into
sonatype-nexus-community:mainfrom
jkowalleck:ci_composer-basic-checks
Draft

basic composer tests in CI#27
jkowalleck wants to merge 2 commits into
sonatype-nexus-community:mainfrom
jkowalleck:ci_composer-basic-checks

Conversation

@jkowalleck

Copy link
Copy Markdown
Contributor

closes #26

@jkowalleck

jkowalleck commented Apr 18, 2021

Copy link
Copy Markdown
Contributor Author

this PR might fail, since current lockfile is wrong/outdated (probably caused by #21).
feel free to rebase my PR onto latest main branch, as soon as this issue was sorted out there.

@bhamail bhamail left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question about my solution to the CI build failure.

Comment thread .circleci/config.yml
executor: << parameters.e >>
steps:
- checkout
- run: composer validate

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to get both build_and_test-1 and build_and_test-2 to succeed in local CI builds by removing the compose validate command. Also not sure if that is a good solution, and would like your thoughts.

@jkowalleck jkowalleck Apr 19, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for reviewing.

to succeed in local CI builds by removing the compose validate command.

removing these lines would miss the point of this PR.
CI found errors, because things were broken, as intriduced by #21 (and fixed by #23)
after #23 got merged to "main" branch, i rebased this PR onto "main" branch. i expect CI tests to pass, now.

unfortunately CI tests were not running after the rebase.
@bhamail are you able to run CI tests in CircleCI manually?

@bhamail bhamail Apr 19, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkowalleck Thanks so much for your explanations - it helps me get a clue!
I think I have successfully resolved the merge conflict and preserved your intention to validate things in the build - but please take a look to make sure I'm on track.

Trying to fix my mess after attempting to resolve merge conflicts. I think it just needs the goodies from main to be happy...however, I'm still seeing memory related failure (locally and in cloud build) in build_and_test-2 via:

circleci config process .circleci/config.yml > .circleci/local-config.yml && circleci local execute -c .circleci/local-config.yml --job 'build_and_test-2'

Here's the local error I'm seeing now:

====>> composer update
  #!/bin/bash -eo pipefail
composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)

Fatal error: Allowed memory size of 1610612736 bytes exhausted (tried to allocate 4096 bytes) in phar:///usr/local/bin/composer/src/Composer/DependencyResolver/RuleWatchGraph.php on line 52

Check https://getcomposer.org/doc/articles/troubleshooting.md#memory-limit-errors for more info on how to handle out of memory errors.Error: Exited with code 255
Step failed

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhamail

I think I have successfully resolved the merge conflict [...]

what merge conflicts? there were no merge conflicts.
I rebased this branch onto "main" without any issues and pushed it to github. see #27 (comment)

i set this PR to be a draft, until things get sorted out.

@jkowalleck jkowalleck marked this pull request as draft April 20, 2021 06:45
@madpah

madpah commented Aug 24, 2021

Copy link
Copy Markdown
Contributor

@bhamail - can we re-run CI against this PR please? The fix accepted in #34 should resolve the CI failures.

FYI @hboutemy

@bhamail

bhamail commented Aug 24, 2021

Copy link
Copy Markdown
Contributor

@madpah Unless there is an objection from @jkowalleck, it may be best to create a new fork with the fixes. I tried re-running the CI builds from this PR, but it would not start.

@madpah

madpah commented Aug 25, 2021

Copy link
Copy Markdown
Contributor

Should be able to close this out in favour of PR #36 @bhamail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] basic composer checks

3 participants