fix: enforce npm audit exit code in frontend CI (#637) - #836
Merged
hman38705 merged 1 commit intoMay 30, 2026
Merged
Conversation
Remove continue-on-error: true from the Scan Node.js dependencies step so high/critical vulnerabilities fail CI. Add exception process comment pointing to frontend/.nsprc for known false positives.
|
@euniceamoni Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
continue-on-error: truefrom theScan Node.js dependenciesstep in.github/workflows/test.ymlso high/critical npm vulnerabilities now fail CI instead of being silently ignored.Changes
continue-on-error: truefrom the npm audit stepfrontend/.nsprcwith justification + security team approval)Testing
CI will now exit non-zero when
npm audit --audit-level=highfinds high or critical vulnerabilities.Closes #637