feat: implement Pyth oracle integration - #805
Merged
hman38705 merged 1 commit intoMay 30, 2026
Merged
Conversation
Replace the pyth_client.rs stub with a full implementation: - Define a Price struct (price, conf, expo, publish_time) matching the official Pyth Soroban SDK type, replacing the raw (i64,u64,i32,i64) tuple - Add get_price_no_older_than to PythOracleInterface so the Pyth contract enforces staleness atomically on-chain (preferred resolution path) - Keep get_price for permissive/test mode (max_staleness_seconds = u64::MAX) - Update oracles.rs to re-export Price as PythPrice for backward compat, use get_price_no_older_than in fetch_pyth_price for production paths, and add secondary confidence validation via validate_price - Feed ID remains configurable per market via OracleConfig.feed_id (64-char hex string decoded to BytesN<32> at call time) - Update MockPythContract in oracles_test.rs to return Price struct and implement get_price_no_older_than with staleness enforcement - Add test_pyth_integration.rs with dedicated integration tests covering: - Feed ID configurable per market and stored independently - get_price path (permissive mode) - get_price_no_older_than path (panics when stale) - validate_price staleness and confidence checks - resolve_with_pyth end-to-end outcome determination - No partial storage written on stale/failed resolution - Multiple oracle IDs are independent per market
|
@Happybello365 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the pyth_client.rs stub with a full implementation:
Description
Type of Change
Testing Done
Checklist
Related Issues
Closes #703