Skip to content

fix: harden market ID generation for high-volume environments#242

Merged
hman38705 merged 2 commits into
solutions-plug:mainfrom
dreamgene:fix/178-market-id-safety
Mar 26, 2026
Merged

fix: harden market ID generation for high-volume environments#242
hman38705 merged 2 commits into
solutions-plug:mainfrom
dreamgene:fix/178-market-id-safety

Conversation

@dreamgene

Copy link
Copy Markdown
Contributor

Closes #178

Summary

  • harden market ID allocation with checked incrementing
  • fail explicitly on ID overflow and on pre-existing ID collisions
  • keep the existing sequential storage model and storage layout intact

Testing

Notes

  • added targeted tests for sequential uniqueness, overflow, collision, and a 1,000,000-ID allocator simulation
  • the repository currently has unrelated compile issues in other modules (for example duplicate contract exports and mismatched module/type usage), so full CLI checks are not green on this branch yet

@drips-wave

drips-wave Bot commented Mar 26, 2026

Copy link
Copy Markdown

@dreamgene Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@hman38705 hman38705 merged commit 15a3083 into solutions-plug:main Mar 26, 2026
2 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Potential Market ID Overflow in DataKey::Market

2 participants