Stop passing line_item to compute unit cancelation adjustment's amount #5278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simple refactoring for the
Spree::UnitCancel
. There's no need to doinventory_unit.line_item
and then pass the line item through everywhere when we can get it through ahas_one
. I also changedweighted_amount
to accept an arbitrary amount instead of a line item object.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: