Utilize Devise Location helpers #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
kennyadsl
reviewed
Sep 15, 2022
| @@ -21,7 +21,7 @@ def provides_callback_for(*providers) | |||
| def omniauth_callback | |||
| if request.env['omniauth.error'].present? | |||
| flash[:error] = I18n.t('devise.omniauth_callbacks.failure', kind: auth_hash['provider'], reason: I18n.t('spree.user_was_not_valid')) | |||
| redirect_back_or_default(root_url) | |||
| redirect_to stored_spree_user_location_or(root_url) | |||
There was a problem hiding this comment.
This assumes we are using the latest version of solidus_auth_devise, which contains the solidusio/solidus_auth_devise#228 and it's not always true. We should probably make it conditional, isn't it?
There was a problem hiding this comment.
We should always be using the latest solidus_auth_devise as the version number is not specified in the gemspec and it should resolve to the latest I would expect. It is true this would break if the user specified solidus_auth_devise 2.5.4, but I feel like we may want to specify in the gemspec rather than create a conditional here. WDYT?
With the deprecation of #redirect_back_or_default in solidus 4.0, we can utilize the SolidusAuthDevise helper stored_location_for to provide the same functionality.
cpfergus1
force-pushed
the
nebulab/remove-redirect-back-or-default
branch
from
31ed644
to
aa75c33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes #redirect_back_or_default in favor of solidus_auth_devise helper methods
Motivation and Context
The method #redirect_back_or_default and the class user_last_url_storer will be deprecated in Solidus solidusio/solidus#4533 which would break the current build without these changes. SolidusAuthDevise has similar a helper method to #redirect_back_or_default, #stored_spree_user_location_or which was introduced in solidusio/solidus_auth_devise#228 and will be utilized instead.
How Has This Been Tested?
The current test suite covers the changes made in the PR