Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Opening this up just for the idea. I initially used a separate
const ErrorHandled = Symbol()
but changed toERROR
.fixes #1895
IMO,
catchError
should work like one we have in the language. It should stop further execution inside the boundary. Everything outside should work as usual.https://playground.solidjs.com/anonymous/a42cb5b3-37b9-4469-9b48-a5fc0d50937e
How did you test this change?
Added a narrowed down test for
catchError
though I'm not sure if there's any other edge cases.pnpm test
seems to pass including the one added.