mark SuspenseListContext
as PURE to allow treeshaking
#2201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing
export { className } from "[email protected]/web";
exports the whole unused reactive utils, seems to me thecreateContext
call forSuspenseListContext
is causing the issue.references:
https://x.com/jlarky/status/1806908281618890951
https://bundlejs.com/?q=solid-js%401.8%2Fweb&treeshake=%5B%7B+className+%7D%5D&config=%7B%22esbuild%22%3A%7B%22minify%22%3Afalse%7D%7D
https://esbuild.github.io/api/#tree-shaking
How did you test this change?
I haven't test this change