Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace broken hope-ui link with kobalte in readme #2181

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

esauri
Copy link
Contributor

@esauri esauri commented Jun 1, 2024

Summary

Currently component libraries links out to https://hope-ui.com/ which no longer works. Looking at the hope-ui repo, we find a working link (https://hope-ui.netlify.app/).

However, this library is deprecated and points to https://pigment.kobalte.dev as a successor. I've opted to instead link to https://kobalte.dev as it has more documented components than the pigment site.

Could also link to https://www.solidjs.com/ecosystem#ui if that is preferred.

How did you test this change?

I clicked some links.

Copy link

changeset-bot bot commented Jun 1, 2024

⚠️ No Changeset found

Latest commit: 6965e4f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@esauri esauri changed the title chore: replace broken hope-ui link with kobalte chore: replace broken hope-ui link with kobalte in readme Jun 1, 2024
@ryansolid ryansolid merged commit c9049dc into solidjs:main Jun 10, 2024
1 check passed
@coveralls
Copy link

coveralls commented Jun 10, 2024

Pull Request Test Coverage Report for Build 9326110473

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.56%

Totals Coverage Status
Change from base Build 9228621029: 0.0%
Covered Lines: 4186
Relevant Lines: 4408

💛 - Coveralls

@esauri esauri deleted the chore/replace-hope-ui-with-kobalte branch June 10, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants