Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forward all args from lazy wrapper to component #2167

Closed
wants to merge 2 commits into from

Conversation

MrFoxPro
Copy link
Contributor

@MrFoxPro MrFoxPro commented May 23, 2024

Summary

Since component is a simple functions and can be called outside of JSX, it can accept multiple arguments. I'm using this to pass some metadata to pages in my custom router.

How did you test this change?

I didn't

Copy link

changeset-bot bot commented May 23, 2024

⚠️ No Changeset found

Latest commit: 455499c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9205120509

Details

  • 3 of 5 (60.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 93.544%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/solid/src/render/component.ts 3 5 60.0%
Totals Coverage Status
Change from base Build 8821517881: -0.02%
Covered Lines: 4187
Relevant Lines: 4410

💛 - Coveralls

@MrFoxPro MrFoxPro changed the title forward all args from wrapper to component forward all args from lazy wrapper to component May 23, 2024
@MrFoxPro MrFoxPro closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants