place json parsing inside the expanded field class

solid-software · Aug 22, 2024 · 62c3d03 · 62c3d03
1 parent a9027cf
commit 62c3d03
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 26 deletions.
diff --git a/lib/src/expanded/invoice_expanded.dart b/lib/src/expanded/invoice_expanded.dart
@@ -1,5 +1,4 @@
 import 'package:stripe/messages.dart';
-import 'package:stripe/src/utils/expandable_fields/invoice_expandable_field.dart';
 
 class InvoiceExpanded {
   final Invoice invoice;
@@ -11,25 +10,4 @@ class InvoiceExpanded {
     this.paymentIntent,
     this.discounts,
   });
-
-  factory InvoiceExpanded.fromJson(
-    Map<String, dynamic> json, {
-    InvoiceExpandableField? expand,
-  }) {
-    PaymentIntent? paymentIntent;
-    if (expand?.paymentIntentExpansion != null) {
-      paymentIntent = expand?.paymentIntentExpansion!.extract(json);
-    }
-
-    List<Discount>? discounts;
-    if (expand?.discountsExpansion != null) {
-      discounts = expand?.discountsExpansion!.extract(json);
-    }
-
-    return InvoiceExpanded(
-      invoice: Invoice.fromJson(json),
-      paymentIntent: paymentIntent,
-      discounts: discounts,
-    );
-  }
 }
diff --git a/lib/src/resources/invoice.dart b/lib/src/resources/invoice.dart
@@ -31,6 +31,6 @@ class InvoiceResource extends Resource<Invoice> {
       },
     );
 
-    return InvoiceExpanded.fromJson(response, expand: expand);
+    return expand.parse(response);
   }
 }
diff --git a/lib/src/utils/expandable_fields/invoice_expandable_field.dart b/lib/src/utils/expandable_fields/invoice_expandable_field.dart
@@ -1,3 +1,4 @@
+import 'package:stripe/messages.dart';
 import 'package:stripe/src/expanded.dart';
 import 'package:stripe/src/utils/expandable_fields/discounts_expandable_field.dart';
 import 'package:stripe/src/utils/expandable_fields/payment_intent_expandable_field.dart';
@@ -23,9 +24,20 @@ class InvoiceExpandableField extends ExpandableObjectField<InvoiceExpanded> {
 
   @override
   InvoiceExpanded parse(Map<String, dynamic> object) {
-    return InvoiceExpanded.fromJson(
-      object,
-      expand: this,
+    PaymentIntent? paymentIntent;
+    if (paymentIntentExpansion != null) {
+      paymentIntent = paymentIntentExpansion!.extract(object);
+    }
+
+    List<Discount>? discounts;
+    if (discountsExpansion != null) {
+      discounts = discountsExpansion!.extract(object);
+    }
+
+    return InvoiceExpanded(
+      invoice: Invoice.fromJson(object),
+      paymentIntent: paymentIntent,
+      discounts: discounts,
     );
   }
-Original file line number
+Diff line change
@@ Expand Up / @@ -31,6 +31,6 @@ class InvoiceResource extends Resource<Invoice> { @@
           },
         );
-        return InvoiceExpanded.fromJson(response, expand: expand);
+        return expand.parse(response);
       }
     }