Skip to content

style: stage UI 수정 #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
enunsnv wants to merge 3 commits into
base: main
Choose a base branch
from
+8 −2
Open

style: stage UI 수정 #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40fc20e
style: border radius 기본값(--radius) 추가
enunsnv Jan 9, 2026
0ac1f1e
style: gray-c 색상 추가 및 SearchBar border 수정
enunsnv Jan 11, 2026
ac3ce56
style: gray-c 색상 추가 및 MyProfileContent bg 색상 수정
enunsnv Jan 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/my/_ui/MyProfileContent/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ const MyProfileContent = () => {
</p>
</div>
{/* Profile Card */}
<div className="mb-4 rounded-lg bg-gray-50 p-4">
<div className="bg-gray-c-300 mb-4 rounded-lg p-4">
Copy link

@coderabbitai coderabbitai bot Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Prettier 오류가 납니다 — 클래스 순서를 정리해주세요.
CI 로그에 맞춰 클래스 순서를 바꿔야 통과합니다.

🧹 수정 제안 
-      <div className="bg-gray-c-300 mb-4 rounded-lg p-4">
+      <div className="mb-4 rounded-lg bg-gray-c-300 p-4">
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<div className="bg-gray-c-300 mb-4 rounded-lg p-4">
<div className="mb-4 rounded-lg bg-gray-c-300 p-4">
🧰 Tools
🪛 GitHub Actions: CI

[error] 83-83: Prettier formatting issue. Replace bg-gray-c-300 mb-4 rounded-lg with mb-4 rounded-lg bg-gray-c-300.

🤖 Prompt for AI Agents 
In `@src/app/my/_ui/MyProfileContent/index.tsx` at line 83, 해당 JSX div의
className("bg-gray-c-300 mb-4 rounded-lg p-4")가 프로젝트의 Prettier/Tailwind 클래스 정렬
규칙을 따르지 않아 CI에서 실패합니다; MyProfileContent 컴포넌트의 해당 div(className 속성)를 프로젝트의 표준
Tailwind 클래스 순서로 재정렬하고 저장 전 Prettier 또는 ESLint --fix를 실행해 자동 정렬을 적용하세요 (대상 식별자:
MyProfileContent 내 문제의 div의 className).

<div className="mb-3 flex items-center space-x-3">
<ProfileWithBadge profileImageUrl={profileImageUrl} width={48} height={48} />
<div>
Expand Down
2 changes: 1 addition & 1 deletion src/app/university/search/SearchBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ const SearchBar = ({ initText }: SearchBarProps) => {
<input
type="text"
placeholder={"해외 파견 학교를 검색하세요."}
className="w-full rounded-lg border border-gray-200 bg-k-50 p-3 pl-4 pr-10 text-k-600 focus:border-primary"
className="border-gray-c-200 w-full rounded-lg border bg-k-50 p-3 pl-4 pr-10 text-k-600 focus:border-primary"
{...register("searchText")}
/>
<div className="absolute right-3 top-1/2 h-5 w-5 -translate-y-1/2 text-gray-400">
Expand Down
4 changes: 4 additions & 0 deletions src/styles/globals.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,3 +70,7 @@
.animate-slide-in {
animation: slide-in 0.3s ease-out;
}

:root {
--radius: 8px;
}
Copy link
Contributor

@manNomi manNomi Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

root 에서 수정하는것이 아닌 테일윈드 config에서 border가 누락된건지 보는게 좋아보여요!
root.css는 전역적인 css지만 저희는 테일윈드로 css 유틸리티를 제어하니까요!

결론
테일윈드 config 값이 제대로 들어가는지 확인필요

2 changes: 2 additions & 0 deletions tailwind.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,8 @@ const config: Config = {
},
"gray-c": {
"100": "#ececec",
"200": "#e5e7eb",
"300": "#f9fafb",
Copy link
Contributor

@manNomi manNomi Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

피그마상에서도 해당 디자인을 가져가나요?
색상이 원래 없었는데 달라져서 그런지 확인한번 해주셔도 좋을것 같아요
피그마 디자인 토큰에 없는 색상인데 누락된것인지 gray-c가 원래 존재하는지 피그마 dev모드 로 확인 해주시면 좋겠네요.

요약

  1. 피그마 dev모드에서 색상확인
  2. 피그마 dev 모드에서 디자인토큰이 gray-c 인지 확인

},
// 하드코딩된 회색 계열 색상
gray: {
Expand Down
Loading