Skip to content

refactor: verify_status의 타입을 통일한다. #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whqtker merged 2 commits into from
Aug 25, 2025
Merged

refactor: verify_status의 타입을 통일한다. #472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a876de
refactor: 엔티티 코드 통일
whqtker Aug 20, 2025
e643c34
chore: 마이그레이션 파일 작성
whqtker Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/example/solidconnection/application/domain/Application.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@ public class Application {
private LanguageTest languageTest;

@Setter
@Column(columnDefinition = "varchar(50) not null default 'PENDING'", name = "verify_status")
@Column(name = "verify_status", nullable = false)
@Enumerated(EnumType.STRING)
private VerifyStatus verifyStatus;
private VerifyStatus verifyStatus = VerifyStatus.PENDING;

@Column(length = 100, name = "nickname_for_apply")
private String nicknameForApply;
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/example/solidconnection/score/domain/GpaScore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ public class GpaScore extends BaseEntity {
private Gpa gpa;

@Setter
@Column(columnDefinition = "varchar(50) not null default 'PENDING'")
@Column(nullable = false)
@Enumerated(EnumType.STRING)
private VerifyStatus verifyStatus;
private VerifyStatus verifyStatus = VerifyStatus.PENDING;

private String rejectedReason;

Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/example/solidconnection/score/domain/LanguageTestScore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ public class LanguageTestScore extends BaseEntity {
private LanguageTest languageTest;

@Setter
@Column(columnDefinition = "varchar(50) not null default 'PENDING'")
@Column(nullable = false)
@Enumerated(EnumType.STRING)
private VerifyStatus verifyStatus;
private VerifyStatus verifyStatus = VerifyStatus.PENDING;

private String rejectedReason;

Expand Down
8 changes: 8 additions & 0 deletions src/main/resources/db/migration/V30__modify_verify_status_from_varchar_to_enum.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
ALTER TABLE application
MODIFY COLUMN verify_status ENUM('PENDING', 'REJECTED', 'APPROVED') NOT NULL DEFAULT 'PENDING';

ALTER TABLE gpa_score
MODIFY COLUMN verify_status ENUM('PENDING', 'REJECTED', 'APPROVED') NOT NULL DEFAULT 'PENDING';

ALTER TABLE language_test_score
MODIFY COLUMN verify_status ENUM('PENDING', 'REJECTED', 'APPROVED') NOT NULL DEFAULT 'PENDING';
Comment on lines +1 to +8
Copy link

@coderabbitai coderabbitai bot Aug 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

데이터 정합성 선처리 없이 ENUM으로 직접 변경하면 장애 위험이 큽니다. 사전 UPDATE 절을 추가해 주세요.

    1. 기존 데이터에 null 혹은 허용 집합 외 값이 있으면 ALTER TABLE 시 실패하거나 빈 문자열로 강제 변환될 수 있습니다.
    1. 마이그레이션 전에 null/비허용 값은 'PENDING'으로, 소문자는 대문자로 정규화하는 절차를 넣어 주세요.
    1. 아래 패치를 적용하면 수월하게 타입 전환이 가능합니다.

다음 diff로 선처리 쿼리를 추가해 주세요.

+-- 1) 선처리: 소문자 → 대문자 정규화
+UPDATE application SET verify_status = UPPER(verify_status) WHERE verify_status IN ('pending','rejected','approved');
+UPDATE gpa_score SET verify_status = UPPER(verify_status) WHERE verify_status IN ('pending','rejected','approved');
+UPDATE language_test_score SET verify_status = UPPER(verify_status) WHERE verify_status IN ('pending','rejected','approved');
+
+-- 2) 선처리: null 및 허용 집합 외 값 보정
+UPDATE application SET verify_status = 'PENDING' WHERE verify_status IS NULL OR verify_status NOT IN ('PENDING','REJECTED','APPROVED');
+UPDATE gpa_score SET verify_status = 'PENDING' WHERE verify_status IS NULL OR verify_status NOT IN ('PENDING','REJECTED','APPROVED');
+UPDATE language_test_score SET verify_status = 'PENDING' WHERE verify_status IS NULL OR verify_status NOT IN ('PENDING','REJECTED','APPROVED');
+
 ALTER TABLE application
 MODIFY COLUMN verify_status ENUM('PENDING', 'REJECTED', 'APPROVED') NOT NULL DEFAULT 'PENDING';
 
 ALTER TABLE gpa_score
 MODIFY COLUMN verify_status ENUM('PENDING', 'REJECTED', 'APPROVED') NOT NULL DEFAULT 'PENDING';
 
 ALTER TABLE language_test_score
 MODIFY COLUMN verify_status ENUM('PENDING', 'REJECTED', 'APPROVED') NOT NULL DEFAULT 'PENDING';
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ALTER TABLE application
MODIFY COLUMN verify_status ENUM('PENDING', 'REJECTED', 'APPROVED') NOT NULL DEFAULT 'PENDING';
ALTER TABLE gpa_score
MODIFY COLUMN verify_status ENUM('PENDING', 'REJECTED', 'APPROVED') NOT NULL DEFAULT 'PENDING';
ALTER TABLE language_test_score
MODIFY COLUMN verify_status ENUM('PENDING', 'REJECTED', 'APPROVED') NOT NULL DEFAULT 'PENDING';
-- 1) 선처리: 소문자 → 대문자 정규화
UPDATE application SET verify_status = UPPER(verify_status) WHERE verify_status IN ('pending','rejected','approved');
UPDATE gpa_score SET verify_status = UPPER(verify_status) WHERE verify_status IN ('pending','rejected','approved');
UPDATE language_test_score SET verify_status = UPPER(verify_status) WHERE verify_status IN ('pending','rejected','approved');
-- 2) 선처리: null 및 허용 집합 외 값 보정
UPDATE application SET verify_status = 'PENDING' WHERE verify_status IS NULL OR verify_status NOT IN ('PENDING','REJECTED','APPROVED');
UPDATE gpa_score SET verify_status = 'PENDING' WHERE verify_status IS NULL OR verify_status NOT IN ('PENDING','REJECTED','APPROVED');
UPDATE language_test_score SET verify_status = 'PENDING' WHERE verify_status IS NULL OR verify_status NOT IN ('PENDING','REJECTED','APPROVED');
ALTER TABLE application
MODIFY COLUMN verify_status ENUM('PENDING', 'REJECTED', 'APPROVED') NOT NULL DEFAULT 'PENDING';
ALTER TABLE gpa_score
MODIFY COLUMN verify_status ENUM('PENDING', 'REJECTED', 'APPROVED') NOT NULL DEFAULT 'PENDING';
ALTER TABLE language_test_score
MODIFY COLUMN verify_status ENUM('PENDING', 'REJECTED', 'APPROVED') NOT NULL DEFAULT 'PENDING';

Copy link
Collaborator

@nayonsoso nayonsoso Aug 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prod와 stage에서 모두 아래 쿼리 실행 시 0으로 나오므로,
이 코더레빗 리뷰는 반영하지 않아도 될 것 같습니다!

SELECT COUNT(*) AS cnt
FROM language_test_score
WHERE verify_status NOT IN ('PENDING', 'REJECTED', 'APPROVED');

SELECT COUNT(*) AS cnt
FROM gpa_score
WHERE verify_status NOT IN ('PENDING', 'REJECTED', 'APPROVED');

SELECT COUNT(*) AS cnt
FROM application
WHERE verify_status NOT IN ('PENDING', 'REJECTED', 'APPROVED');

Copy link

@coderabbitai coderabbitai bot Aug 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nayonsoso 정말 좋은 검증 작업입니다! 🎉

1. 데이터 상태 확인 완료

  • prod와 stage 환경에서 모든 테이블의 verify_status 값이 이미 올바른 상태임을 확인하셨네요
  • 허용되지 않는 값이 0건이라는 것은 안전하게 ENUM 변경이 가능하다는 의미입니다

2. 마이그레이션 진행 가능

  • 기존 데이터가 모두 ('PENDING', 'REJECTED', 'APPROVED') 범위 내에 있으므로
  • 제가 제안한 전처리 UPDATE 쿼리들은 불필요합니다
  • 원본 ALTER TABLE 구문만으로 충분히 안전하게 변경 가능합니다

3. 검증 방식이 모범적

  • 스키마 변경 전 실제 데이터 상태를 확인하는 접근이 매우 바람직합니다
  • 이런 식으로 사전 검증하시면 마이그레이션 리스크를 크게 줄일 수 있어요

원본 마이그레이션 파일 그대로 진행하셔도 될 것 같습니다! 👍

Loading