Skip to content

refactor: 멘토의 마이페이지 응답에 '합격 팁' 추가 #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nayonsoso merged 3 commits into from
Aug 2, 2025
Merged

refactor: 멘토의 마이페이지 응답에 '합격 팁' 추가 #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05bfc17
refactor: 중복되는 페이지네이션 설정 제거
nayonsoso Jul 31, 2025
1177cea
refactor: 멘토의 마이페이지 조회시, '합격 팁'을 포함하도록
nayonsoso Jul 31, 2025
4280c8c
Merge branch 'solid-connection:develop' into refactor/419-include-pas…
nayonsoso Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/main/java/com/example/solidconnection/mentor/controller/MentorController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package com.example.solidconnection.mentor.controller;

import static org.springframework.data.domain.Sort.Direction.DESC;

import com.example.solidconnection.common.dto.SliceResponse;
import com.example.solidconnection.common.resolver.AuthorizedUser;
import com.example.solidconnection.mentor.dto.MentorDetailResponse;
Expand Down Expand Up @@ -41,7 +39,7 @@ public ResponseEntity<SliceResponse<MentorPreviewResponse>> getMentorPreviews(
@AuthorizedUser long siteUserId,
@RequestParam("region") String region,

@PageableDefault(size = 3, sort = "menteeCount", direction = DESC)
@PageableDefault(size = 3)
@SortDefaults({
@SortDefault(sort = "menteeCount", direction = Sort.Direction.DESC),
@SortDefault(sort = "id", direction = Sort.Direction.ASC)
Expand Down
2 changes: 2 additions & 0 deletions src/main/java/com/example/solidconnection/mentor/dto/MentorMyPageResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ public record MentorMyPageResponse(
int menteeCount,
boolean hasBadge,
String introduction,
String passTip,
List<ChannelResponse> channels
) {

Expand All @@ -29,6 +30,7 @@ public static MentorMyPageResponse of(Mentor mentor, SiteUser siteUser, Universi
mentor.getMenteeCount(),
mentor.isHasBadge(),
mentor.getIntroduction(),
mentor.getPassTip(),
mentor.getChannels().stream()
.map(ChannelResponse::from)
.toList()
Expand Down
Loading