Skip to content

Conversation

@nayonsoso
Copy link
Collaborator

@nayonsoso nayonsoso commented Jul 23, 2025

관련 이슈

작업 내용

  • 엔티티의 필드 없앴습니다.
  • flyway 스크립트 작성했습니다.
  • 서비스 코드 & 테스트 코드 고쳤습니다. (성혁님이 워낙 가독성있게 작성해주셔서 빠르게 작업할 수 있었어요 ㅎㅎ)

특이 사항

우리의 논의 #367 가...! 🫠🫠
하지만 유의미한 토론이었다 생각해요 ㅎㅎ

@coderabbitai
Copy link

coderabbitai bot commented Jul 23, 2025

Warning

Rate limit exceeded

@nayonsoso has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 8 minutes and 8 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between d4cd824 and 90d3e87.

📒 Files selected for processing (2)
  • src/test/java/com/example/solidconnection/mentor/fixture/MentoringFixture.java (1 hunks)
  • src/test/java/com/example/solidconnection/mentor/service/MentoringQueryServiceTest.java (1 hunks)

Walkthrough

  1. 멘토링 엔티티 및 관련 코드에서 거절 사유 필드 제거
    • Mentoring 엔티티에서 rejectedReason 필드와 관련 DB 컬럼 애너테이션이 삭제되었습니다.
    • confirm 메서드의 시그니처가 rejectedReason 파라미터 없이 단순화되었습니다.
    • MentoringConfirmRequest DTO에서 rejectedReason 필드가 제거되어, 이제 상태값만 전달받습니다.
    • 서비스 레이어에서 거절 사유 유효성 검증 및 관련 에러 코드 사용이 삭제되었습니다.
    • DB 마이그레이션 스크립트가 추가되어, mentoring 테이블에서 rejected_reason 컬럼이 제거됩니다.
    • 테스트 픽스처(MentoringFixture, MentoringFixtureBuilder)와 서비스 테스트 코드에서 거절 사유 관련 코드와 검증이 삭제 및 정리되었습니다.

Estimated code review effort

2 (~15분)

Suggested reviewers

  • Gyuhyeok99
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@whqtker whqtker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 ~! 변경사항 코멘트 남겼습니다

.mentorId(mentorId)
.menteeId(menteeId)
.verifyStatus(VerifyStatus.REJECTED)
.rejectedReason(rejectedReason)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

파라미터에 rejectedReason 도 제거해야 할 것 같습니다 !

Copy link
Collaborator Author

@nayonsoso nayonsoso Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영했습니다~! 90d3e87

성혁님 진짜.. 어쩜 그렇게 꼼꼼하신가요😭👍👍

Copy link
Member

@whqtker whqtker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경사항 확인했습니다 !

@nayonsoso nayonsoso merged commit 0cfa442 into solid-connection:develop Jul 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: 멘토링 거절 시, 사유를 입력하지 않게 한다.

3 participants