Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified README.md
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class GPA_점수_거절_사유_검증 {
}

@Test
void 거절_상태일_때_거절사유가_없으면_예외_응답을_반환한다() {
void 거절_상태일_때_거절사유가_없으면_예외가_발생한다() {
// given
GpaScoreUpdateRequest request = new GpaScoreUpdateRequest(
3.0,
Expand Down Expand Up @@ -92,7 +92,7 @@ class 어학_점수_거절_사유_검증 {
}

@Test
void 거절_상태일_때_거절사유가_없으면_예외_응답을_반환한다() {
void 거절_상태일_때_거절사유가_없으면_예외가_발생한다() {
// given
LanguageTestScoreUpdateRequest request = new LanguageTestScoreUpdateRequest(
LanguageTestType.TOEIC,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ class GPA_점수_검증_및_수정 {
}

@Test
void 존재하지_않는_GPA_수정_시_예외_응답을_반환한다() {
void 존재하지_않는_GPA_수정_시_예외가_발생한다() {
// given
long invalidGpaScoreId = 9999L;
GpaScoreUpdateRequest request = new GpaScoreUpdateRequest(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ class 어학점수_검증_및_수정 {
}

@Test
void 존재하지_않는_어학점수_수정_시_예외_응답을_반환한다() {
void 존재하지_않는_어학점수_수정_시_예외가_발생한다() {
// given
long invalidLanguageTestScoreId = 9999L;
LanguageTestScoreUpdateRequest request = new LanguageTestScoreUpdateRequest(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ void setUp() {
}

@Test
void 미승인된_GPA_성적으로_지원하면_예외_응답을_반환한다() {
void 미승인된_GPA_성적으로_지원하면_예외가_발생한다() {
// given
GpaScore gpaScore = gpaScoreFixture.GPA_점수(VerifyStatus.PENDING, user);
LanguageTestScore languageTestScore = languageTestScoreFixture.어학_점수(VerifyStatus.APPROVED, user);
Expand All @@ -122,7 +122,7 @@ void setUp() {
}

@Test
void 미승인된_어학성적으로_지원하면_예외_응답을_반환한다() {
void 미승인된_어학성적으로_지원하면_예외가_발생한다() {
// given
GpaScore gpaScore = gpaScoreFixture.GPA_점수(VerifyStatus.APPROVED, user);
LanguageTestScore languageTestScore = languageTestScoreFixture.어학_점수(VerifyStatus.PENDING, user);
Expand All @@ -142,7 +142,7 @@ void setUp() {
}

@Test
void 지원서_수정_횟수를_초과하면_예외_응답을_반환한다() {
void 지원서_수정_횟수를_초과하면_예외가_발생한다() {
// given
GpaScore gpaScore = gpaScoreFixture.GPA_점수(VerifyStatus.APPROVED, user);
LanguageTestScore languageTestScore = languageTestScoreFixture.어학_점수(VerifyStatus.APPROVED, user);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ class 토큰을_재발급한다 {
}

@Test
void 요청의_리프레시_토큰이_저장되어있지_않다면_예외_응답을_반환한다() {
void 요청의_리프레시_토큰이_저장되어있지_않다면_예외가_발생한다() {
// given
String invalidRefreshToken = authTokenProvider.generateAccessToken(new Subject("subject")).token();
ReissueRequest reissueRequest = new ReissueRequest(invalidRefreshToken);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class EmailSignInServiceTest {
class 로그인에_실패한다 {

@Test
void 이메일과_일치하는_사용자가_없으면_예외_응답을_반환한다() {
void 이메일과_일치하는_사용자가_없으면_예외가_발생한다() {
// given
EmailSignInRequest signInRequest = new EmailSignInRequest("이메일", "비밀번호");

Expand All @@ -59,7 +59,7 @@ class 로그인에_실패한다 {
}

@Test
void 비밀번호가_일치하지_않으면_예외_응답을_반환한다() {
void 비밀번호가_일치하지_않으면_예외가_발생한다() {
// given
String email = "testEmail";
siteUserFixture.사용자(email, "testPassword");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ class 토큰으로부터_subject_를_추출한다 {
}

@Test
void 유효하지_않은_토큰의_subject_를_추출하면_예외_응답을_반환한다() {
void 유효하지_않은_토큰의_subject_를_추출하면_예외가_발생한다() {
// given
String subject = "subject123";
String token = createExpiredToken(subject);
Expand Down Expand Up @@ -125,7 +125,7 @@ class 토큰으로부터_claim_을_추출한다 {
}

@Test
void 유효하지_않은_토큰의_claim_을_추출하면_예외_응답을_반환한다() {
void 유효하지_않은_토큰의_claim_을_추출하면_예외가_발생한다() {
// given
String subject = "subject";
Claims expectedClaims = Jwts.claims().setSubject(subject);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class 주어진_회원가입_토큰을_검증한다 {
}

@Test
void 만료되었으면_예외_응답을_반환한다() {
void 만료되었으면_예외가_발생한다() {
// given
String expiredToken = createExpiredToken();

Expand All @@ -91,7 +91,7 @@ class 주어진_회원가입_토큰을_검증한다 {
}

@Test
void 정해진_형식에_맞지_않으면_예외_응답을_반환한다_jwt_가_아닌_토큰() {
void 정해진_형식에_맞지_않으면_예외가_발생한다_jwt_가_아닌_토큰() {
// given
String notJwt = "not jwt";

Expand All @@ -102,7 +102,7 @@ class 주어진_회원가입_토큰을_검증한다 {
}

@Test
void 정해진_형식에_맞지_않으면_예외_응답을_반환한다_authType_클래스_불일치() {
void 정해진_형식에_맞지_않으면_예외가_발생한다_authType_클래스_불일치() {
// given
Map<String, Object> wrongClaim = new HashMap<>(Map.of(AUTH_TYPE_CLAIM_KEY, "카카오"));
String wrongAuthType = createBaseJwtBuilder().addClaims(wrongClaim).compact();
Expand All @@ -114,7 +114,7 @@ class 주어진_회원가입_토큰을_검증한다 {
}

@Test
void 정해진_형식에_맞지_않으면_예외_응답을_반환한다_subject_누락() {
void 정해진_형식에_맞지_않으면_예외가_발생한다_subject_누락() {
// given
Map<String, Object> claim = new HashMap<>(Map.of(AUTH_TYPE_CLAIM_KEY, AuthType.APPLE));
String noSubject = createBaseJwtBuilder().addClaims(claim).compact();
Expand All @@ -126,7 +126,7 @@ class 주어진_회원가입_토큰을_검증한다 {
}

@Test
void 우리_서버에_발급된_토큰이_아니면_예외_응답을_반환한다() {
void 우리_서버에_발급된_토큰이_아니면_예외가_발생한다() {
// given
Map<String, Object> validClaim = new HashMap<>(Map.of(AUTH_TYPE_CLAIM_KEY, AuthType.APPLE));
String signUpToken = createBaseJwtBuilder().addClaims(validClaim).setSubject("email").compact();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ void setUp() {
}

@Test
void 권한이_없는_사용자_접근시_403_예외_응답을_반환한다() throws IOException {
void 권한이_없는_사용자_접근시_403_예외가_발생한다() throws IOException {
// given
AccessDeniedException accessDeniedException = new AccessDeniedException(ACCESS_DENIED.getMessage());

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ void setUp() {
}

@Test
void 인증되지_않은_사용자_접근시_401_예외_응답을_반환한다() throws IOException {
void 인증되지_않은_사용자_접근시_401_예외가_발생한다() throws IOException {
// given
AuthenticationException authException = new AuthenticationServiceException(AUTHENTICATION_FAILED.getMessage());

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ void setUp() {
class security_context_에_저장된_사용자가_없는_경우 {

@Test
void required_가_true_이면_예외_응답을_반환한다() {
void required_가_true_이면_예외가_발생한다() {
// given
MethodParameter parameter = mock(MethodParameter.class);
AuthorizedUser authorizedUser = mock(AuthorizedUser.class);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ class 댓글_생성_테스트 {
}

@Test
void 대대댓글_생성_시도하면_예외_응답을_반환한다() {
void 대대댓글_생성_시도하면_예외가_발생한다() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

253번라인은 반환한다로 되어있습니다!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영했습니다~

// given
Comment parentComment = commentFixture.부모_댓글("부모 댓글", post, user1);
Comment childComment = commentFixture.자식_댓글("자식 댓글", post, user2, parentComment);
Expand All @@ -250,7 +250,7 @@ class 댓글_생성_테스트 {
}

@Test
void 존재하지_않는_부모댓글로_대댓글_작성시_예외를_반환한다() {
void 존재하지_않는_부모댓글로_대댓글_작성시_예외가_빌생한다() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗 여기 오타가 .... 🥲

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

으앗 엄청 열심히 봤는데 저도 놓쳤나보네요.....

// given
long invalidCommentId = 9999L;
CommentCreateRequest request = new CommentCreateRequest(post.getId(), "자식 댓글", invalidCommentId);
Expand Down Expand Up @@ -290,7 +290,7 @@ class 댓글_수정_테스트 {
}

@Test
void 다른_사용자의_댓글을_수정하면_예외_응답을_반환한다() {
void 다른_사용자의_댓글을_수정하면_예외가_발생한다() {
// given
Comment comment = commentFixture.부모_댓글("원본 댓글", post, user1);
CommentUpdateRequest request = new CommentUpdateRequest("수정된 댓글");
Expand All @@ -307,7 +307,7 @@ class 댓글_수정_테스트 {
}

@Test
void 삭제된_댓글을_수정하면_예외_응답을_반환한다() {
void 삭제된_댓글을_수정하면_예외가_발생한다() {
// given
Comment comment = commentFixture.부모_댓글(null, post, user1);
CommentUpdateRequest request = new CommentUpdateRequest("수정된 댓글");
Expand Down Expand Up @@ -398,7 +398,7 @@ class 댓글_삭제_테스트 {
}

@Test
void 다른_사용자의_댓글을_삭제하면_예외_응답을_반환한다() {
void 다른_사용자의_댓글을_삭제하면_예외가_발생한다() {
// given
Comment comment = commentFixture.부모_댓글("부모 댓글", post, user1);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ class 게시글_생성_테스트 {
}

@Test
void 전체_카테고리로_생성하면_예외_응답을_반환한다() {
void 전체_카테고리로_생성하면_예외가_발생한다() {
// given
PostCreateRequest request = createPostCreateRequest(PostCategory.전체.name());
List<MultipartFile> imageFiles = List.of();
Expand All @@ -141,7 +141,7 @@ class 게시글_생성_테스트 {
}

@Test
void 존재하지_않는_카테고리로_생성하면_예외_응답을_반환한다() {
void 존재하지_않는_카테고리로_생성하면_예외가_발생한다() {
// given
PostCreateRequest request = createPostCreateRequest("INVALID_CATEGORY");
List<MultipartFile> imageFiles = List.of();
Expand All @@ -154,7 +154,7 @@ class 게시글_생성_테스트 {
}

@Test
void 이미지를_5개_초과하여_업로드하면_예외_응답을_반환한다() {
void 이미지를_5개_초과하여_업로드하면_예외가_발생한다() {
// given
PostCreateRequest request = createPostCreateRequest(PostCategory.자유.name());
List<MultipartFile> imageFiles = createSixImageFiles();
Expand Down Expand Up @@ -204,7 +204,7 @@ class 게시글_수정_테스트 {
}

@Test
void 다른_사용자의_게시글을_수정하면_예외_응답을_반환한다() {
void 다른_사용자의_게시글을_수정하면_예외가_발생한다() {
// given
SiteUser user2 = siteUserFixture.사용자(2, "test2");
PostUpdateRequest request = createPostUpdateRequest();
Expand All @@ -223,7 +223,7 @@ class 게시글_수정_테스트 {
}

@Test
void 질문_게시글을_수정하면_예외_응답을_반환한다() {
void 질문_게시글을_수정하면_예외가_발생한다() {
// given
PostUpdateRequest request = createPostUpdateRequest();
List<MultipartFile> imageFiles = List.of();
Expand All @@ -241,7 +241,7 @@ class 게시글_수정_테스트 {
}

@Test
void 이미지를_5개_초과하여_수정하면_예외_응답을_반환한다() {
void 이미지를_5개_초과하여_수정하면_예외가_발생한다() {
// given
PostUpdateRequest request = createPostUpdateRequest();
List<MultipartFile> imageFiles = createSixImageFiles();
Expand Down Expand Up @@ -283,7 +283,7 @@ class 게시글_삭제_테스트 {
}

@Test
void 다른_사용자의_게시글을_삭제하면_예외_응답을_반환한다() {
void 다른_사용자의_게시글을_삭제하면_예외가_발생한다() {
// given
SiteUser user2 = siteUserFixture.사용자(2, "test2");

Expand All @@ -298,7 +298,7 @@ class 게시글_삭제_테스트 {
}

@Test
void 질문_게시글을_삭제하면_예외_응답을_반환한다() {
void 질문_게시글을_삭제하면_예외가_발생한다() {
// when & then
assertThatThrownBy(() ->
postCommandService.deletePostById(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ class 게시글_좋아요_테스트 {
}

@Test
void 이미_좋아요한_게시글을_다시_좋아요하면_예외_응답을_반환한다() {
void 이미_좋아요한_게시글을_다시_좋아요하면_예외가_발생한다() {
// given
postLikeService.likePost(user, post.getId());

Expand Down Expand Up @@ -122,7 +122,7 @@ class 게시글_좋아요_취소_테스트 {
}

@Test
void 좋아요하지_않은_게시글을_좋아요_취소하면_예외_응답을_반환한다() {
void 좋아요하지_않은_게시글을_좋아요_취소하면_예외가_발생한다() {
// when & then
assertThatThrownBy(() ->
postLikeService.dislikePost(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public class InterestedCountryRepositoryTest {
class 사용자와_나라는_복합_유니크_제약_조건을_가진다 {

@Test
void 같은_사용자가_같은_나라에_관심_표시를_하면_예외_응답을_반환한다() {
void 같은_사용자가_같은_나라에_관심_표시를_하면_예외가_발생한다() {
// given
SiteUser user = siteUserFixture.사용자();
Country country = countryFixture.미국();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public class InterestedRegionRepositoryTest {
class 사용자와_지역은_복합_유니크_제약_조건을_가진다 {

@Test
void 같은_사용자가_같은_지역에_관심_표시를_하면_예외_응답을_반환한다() {
void 같은_사용자가_같은_지역에_관심_표시를_하면_예외가_발생한다() {
// given
SiteUser user = siteUserFixture.사용자();
Region region = regionFixture.영미권();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ class 멘토_단일_조회_성공 {
class 멘토_단일_조회_실패 {

@Test
void 존재하지_않는_멘토를_조회하면_예외_응답을_반환한다() {
void 존재하지_않는_멘토를_조회하면_예외가_발생한다() {
// given
long notExistingMentorId = 999L;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ class 멘토링_승인_거절_테스트 {
}

@Test
void 거절_시_사유가_없으면_예외_응답을_반환한다() {
void 거절_시_사유가_없으면_예외가_발생한다() {
// given
Mentoring mentoring = mentoringFixture.대기중_멘토링(mentor1.getId(), menteeUser.getId());
MentoringConfirmRequest request = new MentoringConfirmRequest(VerifyStatus.REJECTED, null);
Expand Down Expand Up @@ -178,7 +178,7 @@ class 멘토링_승인_거절_테스트 {
}

@Test
void 존재하지_않는_멘토링_아이디로_요청시_예외_응답을_반환한다() {
void 존재하지_않는_멘토링_아이디로_요청시_예외가_발생한다() {
// given
MentoringConfirmRequest request = new MentoringConfirmRequest(VerifyStatus.APPROVED, null);
long invalidMentoringId = 9999L;
Expand Down Expand Up @@ -219,7 +219,7 @@ class 멘토링_확인_테스트 {
}

@Test
void 존재하지_않는_멘토링_아이디로_요청시_예외_응답을_반환한다() {
void 존재하지_않는_멘토링_아이디로_요청시_예외가_발생한다() {
// given
long invalidMentoringId = 9999L;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ void setUp() {
}

@Test
void 다른_사용자의_소식지를_수정하면_예외_응답을_반환한다() {
void 다른_사용자의_소식지를_수정하면_예외가_발생한다() {
// given
SiteUser anotherUser = siteUserFixture.멘토(2, "anotherMentor");
NewsUpdateRequest request = createNewsUpdateRequest(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ class 소식지_좋아요를_등록한다 {
}

@Test
void 이미_좋아요했으면_예외_응답을_반환한다() {
void 이미_좋아요했으면_예외가_발생한다() {
// given
newsLikeService.addNewsLike(user.getId(), news.getId());

Expand All @@ -109,7 +109,7 @@ class 소식지_좋아요를_취소한다 {
}

@Test
void 좋아요하지_않았으면_예외_응답을_반환한다() {
void 좋아요하지_않았으면_예외가_발생한다() {
// when & then
assertThatCode(() -> newsLikeService.cancelNewsLike(user.getId(), news.getId()))
.isInstanceOf(CustomException.class)
Expand Down
Loading
Loading