Skip to content

refactor: @Repository 어노테이션 안붙이도록 통일 #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Gyuhyeok99 merged 2 commits into from
Jul 1, 2025
Merged

refactor: @Repository 어노테이션 안붙이도록 통일 #360

Gyuhyeok99 merged 2 commits into from
Jul 1, 2025

Conversation

@Gyuhyeok99
Copy link
Contributor

@Gyuhyeok99 Gyuhyeok99 commented Jun 30, 2025

관련 이슈

작업 내용

프로젝트 전반에 거쳐 존재하는 @repository 어노테이션을 제거하였습니다

Spring Data JPA 인터페이스는 @repository 어노테이션을 안 붙여도, 내부적으로 Spring Data JPA의 프록시 생성 로직에서 붙여줍니다.
그렇기에 @repository 붙여도 문제는 없지만, 의미가 중복되고 불필요하여 제거하였습니다.
참고

특이 사항

리뷰 요구사항 (선택)

사용하지 않는 함수들을 여기서 제거할지 고민중입니다 ㅎㅎ..

@Gyuhyeok99 Gyuhyeok99 self-assigned this Jun 30, 2025
@coderabbitai
Copy link

coderabbitai bot commented Jun 30, 2025 •
edited
Loading

Walkthrough

  1. 모든 Repository 인터페이스에서 @Repository 어노테이션이 싹~ 사라졌습니다.
     - 하지만 걱정 마세요! 메소드, 시그니처, 쿼리, 상속 구조는 전혀 손대지 않았습니다.
  2. 몇몇 파일에서는 org.springframework.stereotype.Repository import 구문도 함께 깔끔하게 제거되었습니다.
  3. 각 Repository 인터페이스는 여전히 JpaRepository 또는 커스텀 Repository를 착실히 상속하고 있습니다.
  4. 공개 API나 메소드 시그니처, 쿼리 메소드 등은 전혀 변함이 없습니다.
  5. 이번 변경은 오직 어노테이션과 관련 import를 없앤 것뿐, 내부 로직이나 외부 동작에는 전혀 영향을 주지 않습니다.
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b849803 and ecf33ca.

📒 Files selected for processing (2)
  • src/main/java/com/example/solidconnection/application/repository/ApplicationRepository.java (0 hunks)
  • src/main/java/com/example/solidconnection/university/repository/UniversityRepository.java (0 hunks)
💤 Files with no reviewable changes (2)
  • src/main/java/com/example/solidconnection/university/repository/UniversityRepository.java
  • src/main/java/com/example/solidconnection/application/repository/ApplicationRepository.java
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jun 30, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 45430c9 and b849803.

📒 Files selected for processing (15)
  • src/main/java/com/example/solidconnection/application/repository/ApplicationRepository.java (0 hunks)
  • src/main/java/com/example/solidconnection/community/board/repository/BoardRepository.java (0 hunks)
  • src/main/java/com/example/solidconnection/community/post/repository/PostImageRepository.java (0 hunks)
  • src/main/java/com/example/solidconnection/community/post/repository/PostLikeRepository.java (0 hunks)
  • src/main/java/com/example/solidconnection/community/post/repository/PostRepository.java (0 hunks)
  • src/main/java/com/example/solidconnection/location/country/repository/CountryRepository.java (0 hunks)
  • src/main/java/com/example/solidconnection/location/country/repository/InterestedCountryRepository.java (1 hunks)
  • src/main/java/com/example/solidconnection/location/region/repository/InterestedRegionRepository.java (1 hunks)
  • src/main/java/com/example/solidconnection/location/region/repository/RegionRepository.java (0 hunks)
  • src/main/java/com/example/solidconnection/score/repository/GpaScoreRepository.java (0 hunks)
  • src/main/java/com/example/solidconnection/score/repository/LanguageTestScoreRepository.java (0 hunks)
  • src/main/java/com/example/solidconnection/siteuser/repository/SiteUserRepository.java (0 hunks)
  • src/main/java/com/example/solidconnection/university/repository/LanguageRequirementRepository.java (0 hunks)
  • src/main/java/com/example/solidconnection/university/repository/UniversityInfoForApplyRepository.java (0 hunks)
  • src/main/java/com/example/solidconnection/university/repository/UniversityRepository.java (0 hunks)
💤 Files with no reviewable changes (13)
  • src/main/java/com/example/solidconnection/community/post/repository/PostLikeRepository.java
  • src/main/java/com/example/solidconnection/location/region/repository/RegionRepository.java
  • src/main/java/com/example/solidconnection/university/repository/UniversityRepository.java
  • src/main/java/com/example/solidconnection/community/post/repository/PostImageRepository.java
  • src/main/java/com/example/solidconnection/community/post/repository/PostRepository.java
  • src/main/java/com/example/solidconnection/university/repository/LanguageRequirementRepository.java
  • src/main/java/com/example/solidconnection/community/board/repository/BoardRepository.java
  • src/main/java/com/example/solidconnection/siteuser/repository/SiteUserRepository.java
  • src/main/java/com/example/solidconnection/location/country/repository/CountryRepository.java
  • src/main/java/com/example/solidconnection/application/repository/ApplicationRepository.java
  • src/main/java/com/example/solidconnection/university/repository/UniversityInfoForApplyRepository.java
  • src/main/java/com/example/solidconnection/score/repository/GpaScoreRepository.java
  • src/main/java/com/example/solidconnection/score/repository/LanguageTestScoreRepository.java
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build
🔇 Additional comments (1)
src/main/java/com/example/solidconnection/location/region/repository/InterestedRegionRepository.java (1)

9-11: 불필요한 @repository 제거 👍

  1. @Repository 어노테이션을 걷어내어 Spring Data JPA가 자동 부여하는 프록시 빈에 맡기는 방향으로 일관성을 확보하셨네요.
    깔끔하고 문제 없습니다!

whqtker
whqtker approved these changes Jun 30, 2025
View reviewed changes
Copy link
Member

@whqtker whqtker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 미사용 함수 제거하는 건 동의합니다.

nayonsoso
nayonsoso approved these changes Jul 1, 2025
View reviewed changes
Copy link
Collaborator

@nayonsoso nayonsoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다 ~ 👏👏

많이 번거롭지 않을 것 같기도 하고, 완전히 내용이 다르다고 생각이 들어서요!
다른 PR에서 하는건 어떤가요?

성혁님이랑 제 의견이 다르긴 한데, 이 내용은 규혁님 듣고 싶은 의견 따르셔도 됩니다.
(무조건 다른 PR에서 하라는 이야기 아님 / 취사 반영해도 되는 의견!)

@Gyuhyeok99
Merge remote-tracking branch 'origin/develop' into refactor/357-remov…
ecf33ca 
…e-repository-annotation

# Conflicts:
#	src/main/java/com/example/solidconnection/university/repository/UniversityInfoForApplyRepository.java
#	src/main/java/com/example/solidconnection/university/repository/UniversityRepository.java
@Gyuhyeok99
Copy link
Contributor Author

Gyuhyeok99 commented Jul 1, 2025

새 Pr에서 하도록 하겠습니다!

@Gyuhyeok99 Gyuhyeok99 merged commit bacdbbb into solid-connection:develop Jul 1, 2025
2 checks passed
@Gyuhyeok99 Gyuhyeok99 deleted the refactor/357-remove-repository-annotation branch July 10, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@whqtker whqtker whqtker approved these changes

@nayonsoso nayonsoso nayonsoso approved these changes

@wibaek wibaek Awaiting requested review from wibaek wibaek is a code owner

@lsy1307 lsy1307 Awaiting requested review from lsy1307 lsy1307 is a code owner

Assignees

@Gyuhyeok99 Gyuhyeok99

Labels

리팩터링

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

refactor: @Repository 어노테이션 안붙이도록 통일

3 participants

@Gyuhyeok99 @whqtker @nayonsoso