-
Notifications
You must be signed in to change notification settings - Fork 8
refactor: '대학교'와 '대학 지원 정보' 용어를 구분하도록 #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nayonsoso
merged 25 commits into
solid-connection:develop
from
nayonsoso:refactor/344-clarify-university-terminology
Jul 1, 2025
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
fe244b6
refactor: univ-apply-info로 URI 변경
nayonsoso bd3e1f3
refactor: UnivApplyInfo 사용하도록 컨트롤러 함수 변경
nayonsoso ed9f849
refactor: UnivApplyInfo 사용하도록 recommendService 변경
nayonsoso 348edb4
refactor: UnivApplyInfo 사용하도록 레포지토리 이름 변경
nayonsoso 9b5c63e
refactor: JPQL alias 변경
nayonsoso 373093d
refactor: JPA 표준에 맞게 함수 이름 변경
nayonsoso ded3bb4
refactor: UnivApplyInfo 사용하도록 레포지토리 변경
nayonsoso 27c2079
refactor: JPA 표준에 맞게 함수 이름 변경
nayonsoso 3d5c0b4
refactor: UnivApplyInfo 반영하도록 JPQL 별칭 변경
nayonsoso 46cdeda
refactor: 잘못되어있던 상속 관계 변경
nayonsoso 2e3719b
refactor: 좋아요한 대학 도메인 이름 변경
nayonsoso 2ff17bb
refactor: UnivApplyInfo 사용하도록 likeService 변경
nayonsoso 9bbb2b8
refactor: LikedUnivApplyInfoRepository 패키지 이동
nayonsoso 2e684c6
refactor: UnivApplyInfo 사용하도록 Dto 이름 변경
nayonsoso 6cc1023
refactor: UnivApplyInfo 사용하도록 테스트 코드 변경
nayonsoso cf63e1d
refactor: UNIV_APPLY_INFO 사용하도록 ErrorCode 변경
nayonsoso 0bde961
refactor: 지원자 응답 Dto 이름 변경
nayonsoso fa91c81
refactor: UnivApplyInfo 사용하도록 applicationService 변경
nayonsoso 2834221
refactor: JPA 표준에 맞게 함수 이름 변경
nayonsoso 0b2bfa1
chore: 추후 수정해야 할 부분 표시
nayonsoso 0443d3b
refactor: UnivApplyInfo 사용하도록 Dto필드명 변경
nayonsoso 00f13d6
refactor: 이름변경 누락된 부분 수정
nayonsoso 6bf9076
refactor: 테스트 코드에서 이름변경 누락된 부분 수정
nayonsoso f781751
refactor: UnivApplyInfo 사용하도록 MyPageService 변경
nayonsoso 2271c6e
refactor: 사용되지 않는 함수 삭제
nayonsoso File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
src/main/java/com/example/solidconnection/application/dto/UnivApplyInfoChoiceRequest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| package com.example.solidconnection.application.dto; | ||
|
|
||
| import com.example.solidconnection.university.dto.validation.ValidUnivApplyInfoChoice; | ||
| import com.fasterxml.jackson.annotation.JsonProperty; | ||
|
|
||
| @ValidUnivApplyInfoChoice | ||
| public record UnivApplyInfoChoiceRequest( | ||
|
|
||
| @JsonProperty("firstChoiceUniversityId") | ||
| Long firstChoiceUnivApplyInfoId, | ||
|
|
||
| @JsonProperty("secondChoiceUniversityId") | ||
| Long secondChoiceUnivApplyInfoId, | ||
|
|
||
| @JsonProperty("thirdChoiceUniversityId") | ||
| Long thirdChoiceUnivApplyInfoId) { | ||
| } |
10 changes: 0 additions & 10 deletions
10
src/main/java/com/example/solidconnection/application/dto/UniversityChoiceRequest.java
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 0 additions & 18 deletions
18
src/main/java/com/example/solidconnection/siteuser/repository/LikedUniversityRepository.java
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.