Skip to content

feat: News 소식지 도메인 추가 #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wibaek merged 4 commits into from
May 11, 2025
Merged

feat: News 소식지 도메인 추가 #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5be212b
feat: News 소식지 도메인 추가
wibaek May 9, 2025
134b2de
chore: import 수정
wibaek May 9, 2025
4491c8a
feat: 뉴스 테이블 생성 Flyway 스키마 추가
wibaek May 10, 2025
eccce37
chore: Flyway 파일 포매팅
wibaek May 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified README.md
View file
Open in desktop
Binary file not shown.
32 changes: 32 additions & 0 deletions src/main/java/com/example/solidconnection/news/domain/News.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
package com.example.solidconnection.news.domain;

import com.example.solidconnection.entity.common.BaseEntity;
import jakarta.persistence.Column;
import jakarta.persistence.Entity;
import jakarta.persistence.GeneratedValue;
import jakarta.persistence.GenerationType;
import jakarta.persistence.Id;
import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.NoArgsConstructor;

@Getter
@Entity
@NoArgsConstructor
Copy link

@coderabbitai coderabbitai bot May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

⚠️ Potential issue

3. 생성자 또는 빌더 구현 필요 (치명적)
현재 @NoArgsConstructor만 적용되어 있어 News 인스턴스를 생성할 방법이 없습니다. 다음 중 하나를 필수로 도입해주세요:

  1. 생성자 추가
    생성자에 title, description, thumbnailUrl, url 필드를 파라미터로 받도록 선언
  2. @Builder 적용
    Lombok의 빌더 패턴을 사용하여 안정적인 인스턴스 생성 지원
  3. 정적 팩토리 메서드 구현
    News.of(...)와 같은 명확한 생성 방식을 제공

@EqualsAndHashCode
public class News extends BaseEntity {

@Id
@GeneratedValue(strategy = GenerationType.IDENTITY)
private Long id;

private String title;

private String description;

@Column(length = 500)
private String thumbnailUrl;

@Column(length = 500)
private String url;
}
10 changes: 10 additions & 0 deletions src/main/resources/db/migration/V12__create_news.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
CREATE TABLE news (
created_at datetime(6),
id bigint not null auto_increment,
updated_at datetime(6),
thumbnail_url varchar(500),
url varchar(500),
description varchar(255),
title varchar(255),
primary key (id)
)
Loading