Skip to content

fix(validate): don't report uninitialized submodules as broken links #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ernanibmurtinho wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(validate): don't report uninitialized submodules as broken links #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 31 additions & 5 deletions validate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,23 @@ set -euo pipefail

PASS=0
FAIL=0
SKIP=0

# A path lives under an ext/ submodule; if that submodule dir is empty it isn't
# initialized (fresh clone without --recurse-submodules, or before install.sh) —
# a setup state, NOT broken config. Return 0 when the path is inside an
# uninitialized submodule so callers can SKIP instead of FAIL.
in_uninitialized_submodule() {
local path="$1"
case "$path" in
.claude/skills/ext/*)
local sub
sub="$(printf '%s' "$path" | sed -E 's#(\.claude/skills/ext/[^/]+).*#\1#')"
[ -d "$sub" ] && [ -z "$(ls -A "$sub" 2>/dev/null)" ]
;;
*) return 1 ;;
esac
}

check() {
local description="$1"
Expand Down Expand Up @@ -71,9 +88,13 @@ if [ -f .claude/skills/SKILL.md ]; then

target=".claude/skills/$link"
if [ ! -e "$target" ] && [ ! -d "$target" ]; then
echo " FAIL: Broken link -> $link"
FAIL=$((FAIL + 1))
broken=$((broken + 1))
if in_uninitialized_submodule "$target"; then
SKIP=$((SKIP + 1))
else
echo " FAIL: Broken link -> $link"
FAIL=$((FAIL + 1))
broken=$((broken + 1))
fi
fi
done < <(grep -oE '\]\([^)]+\)' .claude/skills/SKILL.md | sed 's/\](//' | sed 's/)//' | grep -v '^http')

Expand All @@ -90,7 +111,8 @@ echo "[Submodules]"
for dir in .claude/skills/ext/*/; do
name="$(basename "$dir")"
if [ -z "$(ls -A "$dir" 2>/dev/null)" ]; then
check "ext/$name is initialized (non-empty)" 1
echo " SKIP: ext/$name not initialized (run: git submodule update --init)"
SKIP=$((SKIP + 1))
else
check "ext/$name is initialized (non-empty)" 0
fi
Expand Down Expand Up @@ -171,7 +193,11 @@ echo ""
# --- Summary ---
TOTAL=$((PASS + FAIL))
echo "========================================="
echo "Results: $PASS passed, $FAIL failed (of $TOTAL checks)"
echo "Results: $PASS passed, $FAIL failed, $SKIP skipped (of $((TOTAL + SKIP)) checks)"
if [ "$SKIP" -gt 0 ]; then
echo "Note: $SKIP checks skipped because submodules aren't initialized."
echo " Run 'git submodule update --init --recursive' (or ./install.sh) to check them."
fi
echo "========================================="

if [ "$FAIL" -gt 0 ]; then
Expand Down