fix: auto-index silently never fires on batched increments - #7
Open
gamandeepsingh wants to merge 1 commit into
Open
fix: auto-index silently never fires on batched increments#7gamandeepsingh wants to merge 1 commit into
gamandeepsingh wants to merge 1 commit into
Conversation
…to allow incremented counts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*count == thresholdonly matched when the count landed exactly on the threshold, which worked for one-by-one increments but silently dropped entries when a batch flush pushed the count past it in one go (e.g. 0→15 with threshold=10).Changed to
*count < threshold + increment— equivalent to checkingprevious_count < threshold— so the entry is added to the priority queue on the genuine first crossing, regardless of batch size, without re-triggering after the queue consumes it.Closes: #2