fix: confirmed slot gap during startup causes unrecoverable crash-loop - #27
Open
gamandeepsingh wants to merge 1 commit into
Open
fix: confirmed slot gap during startup causes unrecoverable crash-loop#27gamandeepsingh wants to merge 1 commit into
gamandeepsingh wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: confirmed slot gap during startup causes unrecoverable crash-loop
On large databases the post-snapshot pipeline (dedup, index creation, cleanup) runs for several hours with finalization paused. During that window the gRPC buffer fills up, back-pressures the stream, and the upstream drops a slot — triggering a confirmed gap.
check_slot_gapthen paused the finalizer, which is the very worker that drives startup to completion, creating a deadlock.fill_gapsdetected startup wasn't done andpanic!'d, restarting the entire process and re-downloading the full snapshot. On a ~108 GB mainnet index this loop is unrecoverable.Fix:
SelfHealingStatenow holds a reference tosnapshot_processing_state. Incheck_slot_gap, the finalizer is only paused if startup is already finished — gaps detected during startup are still queued for repair but the finalizer keeps running.fill_gaps, thepanic!is replaced withcontinue. The loop retries every 30s until startup finishes, then pauses the finalizer and repairs the queued gaps through the normal path.Closes: #19