Skip to content

chore: change package naming, addd publish ci #60

Merged
stevesarmiento merged 3 commits intomainfrom
package-prep
Feb 2, 2026
Merged

chore: change package naming, addd publish ci #60
stevesarmiento merged 3 commits intomainfrom
package-prep

Conversation

@stevesarmiento
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Feb 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
mosaic Ready Ready Preview, Comment Feb 2, 2026 3:57am

Request Review

@greptile-apps
Copy link

greptile-apps bot commented Feb 2, 2026

Greptile Overview

Greptile Summary

This PR renames packages from @mosaic/* to @solana/* namespace and adds CI/CD workflow for npm publishing.

  • Package names changed: @mosaic/sdk@solana/mosaic-sdk, @mosaic/cli@solana/mosaic-cli
  • All import statements across 50+ files updated to use new package names
  • Documentation (README, CLAUDE.md) updated with new package references
  • New GitHub Actions workflow added for publishing to npm with manual dispatch option
  • Lockfile correctly regenerated with workspace references intact

Critical issue found: The publish workflow is missing npm authentication. The workflow has id-token: write permission but doesn't configure NODE_AUTH_TOKEN or use the --provenance flag for trusted publishing, which will cause publish steps to fail.

Confidence Score: 3/5

  • Package rename is safe, but CI workflow has authentication issues that will block publishing
  • The package renaming is thorough and correctly applied across all files, but the npm publish workflow is missing authentication configuration, making it non-functional
  • .github/workflows/publish-sdks.yml requires npm authentication setup before merge

Important Files Changed

Filename Overview
.github/workflows/publish-sdks.yml New CI workflow for publishing packages to npm using trusted publishing, includes manual dispatch option
packages/sdk/package.json Package name changed from @mosaic/sdk to @solana/mosaic-sdk
packages/cli/package.json Package name changed from @mosaic/cli to @solana/mosaic-cli, dependency updated to @solana/mosaic-sdk
apps/app/package.json Dependency updated from @mosaic/sdk to @solana/mosaic-sdk
pnpm-lock.yaml Lockfile updated to reflect package name changes with correct workspace references
README.md Documentation updated to reference new package names @solana/mosaic-sdk and @solana/mosaic-cli

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant GH as GitHub
    participant CI as CI Workflow
    participant NPM as npm Registry

    alt Tag Push
        Dev->>GH: Push tag (v*)
        GH->>CI: Trigger publish-packages job
    else Manual Dispatch
        Dev->>GH: Manual workflow trigger
        Note over Dev,GH: Select package: all/sdk/cli
        GH->>CI: Trigger publish-packages job
    end

    CI->>CI: Checkout code
    CI->>CI: Setup Node.js + pnpm
    CI->>CI: Install dependencies (frozen-lockfile)
    CI->>CI: Build all packages
    CI->>CI: Skip tests

    alt Publish SDK
        CI->>NPM: npm publish @solana/mosaic-sdk (--access public)
    end

    alt Publish CLI
        CI->>NPM: npm publish @solana/mosaic-cli (--access public)
    end

    alt Tag Push Only
        CI->>CI: Trigger create-release job
        CI->>CI: Compute release version
        CI->>GH: Create GitHub Release
        Note over CI,GH: Include package info & install instructions
    end
Loading

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

@stevesarmiento stevesarmiento merged commit 8b26fb6 into main Feb 2, 2026
3 checks passed
@greptile-apps greptile-apps bot mentioned this pull request Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant