Skip to content

fix NumberAsHex to support negative hex values #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
feltroidprime wants to merge 1 commit into
base: development
Choose a base branch
from
Open

fix NumberAsHex to support negative hex values #1680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions starknet_py/net/schemas/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class NumberAsHex(fields.Field):
"""

MAX_VALUE = sys.maxsize
REGEX_PATTERN = r"^0x[a-fA-F0-9]+$"
REGEX_PATTERN = r"^-?0x[a-fA-F0-9]+$"

def _serialize(self, value: Any, attr: Optional[str], obj: Any, **kwargs):
if self._is_int_and_in_range(value):
Expand Down Expand Up @@ -72,7 +72,7 @@ def _deserialize(
)

def _is_int_and_in_range(self, value: Any) -> bool:
return isinstance(value, int) and 0 <= value < self.MAX_VALUE
return isinstance(value, int) and -self.MAX_VALUE < value < self.MAX_VALUE

def _is_str_and_valid_pattern(self, value: Any) -> bool:
return (
Expand Down
Loading