Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add bun support #88

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: add bun support #88

wants to merge 3 commits into from

Conversation

wcastand
Copy link

@wcastand wcastand commented Aug 28, 2024 •
edited
Loading

to support : #87

  • added bun to templates (need to verify --cwd does what i expect)
  • added bun detection in the package manager
  • add to the github action bun bin (- uses: oven-sh/setup-bun@v2)

left to do as far as i know:

  • see if gluegun can support bun easily or not
  • check what kind of tests i need to run to check it works as intended

@wcastand wcastand changed the title add bun in templates and in detecting the package manager add bun support Aug 28, 2024
@wcastand wcastand changed the title add bun support feat: add bun support Aug 28, 2024
@wcastand
Copy link
Author

currently block since i realize gluegun doesn't support bun as a package manager.
infinitered/gluegun#794

@maciekstosio
Copy link
Collaborator

maciekstosio commented Aug 30, 2024 •
edited
Loading

currently block since i realize gluegun doesn't support bun as a package manager.

Yeah, that's why we didn't include bun and pnpm in the alpha version. If you're still interested in contributing I think create-expo-stack handles all of them and we could learn from it: https://github.com/roninoss/create-expo-stack/blob/main/cli/src/utilities/getPackageManager.ts

@wcastand
Copy link
Author

wcastand commented Aug 30, 2024 •
edited
Loading

from what i understood of their codebase (quick look might be more to that)
they basically don't use gluegun packageManager, what block us is we use force option of gluegun packageManager from toolbox and from what i can see, they don't use the packageManager from the toolbox and handle it on their own or differently(didn't find an equivalent yet from my quick look)

they don't have extensions which is where we do the force related things, probably why they can manage bun and pnpm even using gluegun.

szarbartosz
szarbartosz reviewed Oct 31, 2024
View reviewed changes
src/templates/detox/test-detox-ios.ejf
@@ -37,6 +39,11 @@ jobs:
- name: 🏗 Checkout repository
uses: actions/checkout@v4

<%= if(props.packageManager === "bun") { %>
- name: Install Bun
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Install Bun
- name: 🥟 Install Bun

szarbartosz
szarbartosz reviewed Oct 31, 2024
View reviewed changes
src/templates/eas/eas-update.ejf
@@ -31,6 +32,11 @@ jobs:
- name: 🏗 Setup repo
uses: actions/checkout@v4

<%= if(props.packageManager === "bun") { %>
- name: Install Bun
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Install Bun
- name: 🥟 Install Bun

szarbartosz
szarbartosz reviewed Oct 31, 2024
View reviewed changes
src/templates/jest/jest.ejf
@@ -27,6 +29,11 @@ jobs:
- name: 🏗 Setup repo
uses: actions/checkout@v4

<%= if(props.packageManager === "bun") { %>
- name: Install Bun
Copy link

@szarbartosz szarbartosz Oct 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Install Bun
- name: 🥟 Install Bun

szarbartosz
szarbartosz reviewed Oct 31, 2024
View reviewed changes
src/templates/lint/lint.ejf
@@ -27,6 +29,11 @@ jobs:
- name: 🏗 Setup repo
uses: actions/checkout@v4

<%= if(props.packageManager === "bun") { %>
- name: Install Bun
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Install Bun
- name: 🥟 Install Bun

szarbartosz
szarbartosz reviewed Oct 31, 2024
View reviewed changes
src/templates/prettier/prettier.ejf
@@ -27,6 +29,11 @@ jobs:
- name: 🏗 Setup repo
uses: actions/checkout@v4

<%= if(props.packageManager === "bun") { %>
- name: Install Bun
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Install Bun
- name: 🥟 Install Bun

szarbartosz
szarbartosz reviewed Oct 31, 2024
View reviewed changes
src/templates/typescript/typescript.ejf
@@ -27,6 +29,11 @@ jobs:
- name: 🏗 Setup repo
uses: actions/checkout@v4

<%= if(props.packageManager === "bun") { %>
- name: Install Bun
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Install Bun
- name: 🥟 Install Bun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szarbartosz szarbartosz szarbartosz left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wcastand @maciekstosio @szarbartosz