fix: do not print generic error message for expected errors #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciekstosio
previously approved these changes
Sep 19, 2024
src/extensions/interactive.ts
Outdated
| @@ -123,7 +123,7 @@ module.exports = (toolbox: CycliToolbox) => { | |||
| }).prompt() | |||
|
|
|||
| if (isCancel(confirmed)) { | |||
| throw Error('The script execution has been canceled by the user.') | |||
| throw CycliError('The script execution has been canceled by the user.') | |||
There was a problem hiding this comment.
Maybe we should also have some predefined errors so we don't repeat this every time? Like const CycliErrorCanceled = new CycliError(...), wdyt?
There was a problem hiding this comment.
It could be even just here at the top of file as it seems to be just in this file.
There was a problem hiding this comment.
good idea, done in 8cc3ad7
maciekstosio
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #21
Before
After