cairo-lang-macro fix null-byte panics
#1677
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 24, 2024
Merged
Merged
Merged
mkaput
reviewed
Oct 25, 2024
| @@ -95,7 +95,9 @@ impl TokenStream { | |||
| /// | |||
| /// # Safety | |||
| #[doc(hidden)] | |||
| pub fn into_stable(self) -> StableTokenStream { | |||
| pub fn into_stable(mut self) -> StableTokenStream { | |||
| // Remove 0 bytes so conversion will always work. | |||
There was a problem hiding this comment.
have you managed to find out why these null bytes where there?
There was a problem hiding this comment.
Sadly no, this is workaround for it.
Draggu
force-pushed
the
spr/main/e5393b42
branch
from
7e4347c
to
b07cfb1
Compare
Merged
commit-id:34f01829
Draggu
force-pushed
the
spr/main/e5393b42
branch
from
b07cfb1
to
fb875eb
Compare
commit-id:e5393b42
Draggu
force-pushed
the
spr/main/e5393b42
branch
from
fb875eb
to
0ea403c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.