Revert "perf: Convert events to jsi::Value without a JSON round-trip in handleEvent"#9687
Merged
tomekzaw merged 1 commit intoJun 17, 2026
Conversation
…p in `ha…" This reverts commit 59909c9.
bartlomiejbloniarz
approved these changes
Jun 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the previously introduced optimization that converted Android event payloads to jsi::Value without a JSON round-trip in NativeProxy::handleEvent, restoring the older JSON-stringify + JSON-parse approach for event payload conversion.
Changes:
- Reintroduces JSON serialization/deserialization in
handleEvent(WritableMap::toString()→jsi::Value::createFromJsonUtf8). - Removes now-unneeded includes related to the reverted direct conversion path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #9581
#9581 made
handleEventconsume the incoming event payload map viaNativeMap::consume(), which moves out itsfolly::dynamicand marks the map consumed. That map is owned by the React Native event and is also dispatched to JS, and some events return a cached instance fromgetEventData(), so consuming it in Reanimated corrupts the downstream dispatch and throwsObjectAlreadyConsumedException: Map already consumedon Android. Reverting to be safe for the 4.5.0 release; a fixed version that keeps the optimization is in #9686.Confirmed crashes:
MapLibre
MapChangeEvent:Expo view events (
KEventEmitterWrapper.UIEvent, for example expo-image):