Skip to content

feat(Worklets): patch RN with BundleConsumer TurboModule APIs#7644

Closed
tjzel wants to merge 4 commits into
mainfrom
@tjzel/worklets/turbo-module-apis-for-bundle
Closed

feat(Worklets): patch RN with BundleConsumer TurboModule APIs#7644
tjzel wants to merge 4 commits into
mainfrom
@tjzel/worklets/turbo-module-apis-for-bundle

Conversation

@tjzel

@tjzel tjzel commented Jun 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

Previously my patch to RN would make it obtain WorkletsModule by hard-coding it in the right place. In this patch I'm actually obtaining WorkletsModule via a new API (almost) without hardcoding anything. You can look at the changes in my PR to RN:

I'm also fixing the patch code affecting initialization queues on iOS with experimental bundling disabled.

Test plan

I checked the following configurations:

  • iOS debug
    • legacy bundling
    • experimental bundling
  • iOS prod
    • legacy bundling
    • experimental bundling
  • android debug
    • legacy bundling
    • experimental bundling
  • android prod
    • legacy bundling
    • experimental bundling

@tjzel tjzel requested review from Copilot, piaskowyk and tomekzaw and removed request for Copilot June 10, 2025 14:16

This comment was marked as resolved.

Sign in to view

@tjzel

tjzel commented Jun 16, 2025

Copy link
Copy Markdown
Collaborator Author

I accidentally shipped these changes in

@tjzel tjzel closed this Jun 16, 2025
@tjzel tjzel mentioned this pull request Jun 24, 2025
Merged
github-merge-queue Bot pushed a commit that referenced this pull request Jun 26, 2025
@tjzel
chore(Worklets): add missing codegen for iOS experimental bundling (#…
97c175e 
…7689)

## Summary

It was added in
#7644
but I forgot about it in
#7657.

Without it experimental bundling won't work on iOS.

## Test plan

This codegen field has no effect with `experimentalBundling` disabled.
@tjzel tjzel deleted the @tjzel/worklets/turbo-module-apis-for-bundle branch October 3, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@piaskowyk piaskowyk piaskowyk approved these changes

@tomekzaw tomekzaw Awaiting requested review from tomekzaw

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tjzel @piaskowyk