Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix deprecated this captures in lambdas for NDK 27 #6495

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

tjzel
Copy link
Collaborator

@tjzel tjzel commented Sep 8, 2024

Summary

-Wall and -Werror in NDK 27 make deprecation warnings fail the compilation process. NDK 27 isn't yet used in React Native, therefore this is more of a feature than a fix.

Fixes #6466

@tjzel tjzel added this pull request to the merge queue Sep 9, 2024
Merged via the queue into main with commit d6b6421 Sep 9, 2024
17 checks passed
@tjzel tjzel deleted the @tjzel/common/fix-deprecated-lambdas branch September 9, 2024 08:21
tjzel added a commit that referenced this pull request Sep 13, 2024
## Summary

`-Wall` and `-Werror` in NDK 27 make deprecation warnings fail the
compilation process. NDK 27 isn't yet used in React Native, therefore
this is more of a feature than a fix.

Fixes
#6466
github-merge-queue bot pushed a commit that referenced this pull request Sep 27, 2024
## Summary

Turns out preliminary support for NDK27 in
- #6495

broke support for NDK23. This PR brings back support for NDK23 which is
used in React Native 0.72.

## Test plan

- [ ] All GitHub actions pass.

## Notes

Fixes
- #6512
tjzel added a commit that referenced this pull request Oct 1, 2024
Turns out preliminary support for NDK27 in
- #6495

broke support for NDK23. This PR brings back support for NDK23 which is
used in React Native 0.72.

- [ ] All GitHub actions pass.

Fixes
- #6512
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build failled react reanimated 3.15.1
2 participants