Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add Entering/Exiting Playground #6468

Merged
merged 9 commits into from
Sep 20, 2024
Merged

docs: add Entering/Exiting Playground #6468

merged 9 commits into from
Sep 20, 2024

Conversation

patrycjakalinska
Copy link
Contributor

@patrycjakalinska patrycjakalinska commented Aug 30, 2024 •
edited
Loading

image
Screen.Recording.2024-09-03.at.15.03.46.mov

Test plan

  1. yarn && yarn start
  2. Test if animations behave correctly.

@patrycjakalinska patrycjakalinska marked this pull request as ready for review September 3, 2024 13:07
headfire94
headfire94 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@headfire94 headfire94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, good idea

tjzel
tjzel reviewed Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@tjzel tjzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, let's just tackle some inconsitencies in the code underneath.

...mated/src/components/InteractivePlayground/useEnteringExitingAnimationPlayground/Example.tsx Show resolved Hide resolved
...mated/src/components/InteractivePlayground/useEnteringExitingAnimationPlayground/Example.tsx Outdated Show resolved Hide resolved
...mated/src/components/InteractivePlayground/useEnteringExitingAnimationPlayground/Example.tsx Outdated Show resolved Hide resolved
...mated/src/components/InteractivePlayground/useEnteringExitingAnimationPlayground/Example.tsx Show resolved Hide resolved
...nimated/src/components/InteractivePlayground/useEnteringExitingAnimationPlayground/index.tsx Outdated Show resolved Hide resolved
...nimated/src/components/InteractivePlayground/useEnteringExitingAnimationPlayground/index.tsx Outdated Show resolved Hide resolved
...nimated/src/components/InteractivePlayground/useEnteringExitingAnimationPlayground/index.tsx Outdated Show resolved Hide resolved
@patrycjakalinska patrycjakalinska force-pushed the @patrycjakalinska/entering-exiting-examples branch from d1885bf to 5ec30e8 Compare September 9, 2024 11:44
@tjzel tjzel mentioned this pull request Sep 9, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 9, 2024
@tjzel
chore: Bump prettier in docs (#6497)
1754695 
## Summary

After bumping Prettier in the monorepo docs should have it bumped too
since they inherit `prettier.config.js`.

Fixes CI failing in:
- #6467 
- #6468
@patrycjakalinska patrycjakalinska force-pushed the @patrycjakalinska/entering-exiting-examples branch from 5f0bcd4 to 824a748 Compare September 9, 2024 13:16
tjzel
tjzel reviewed Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@tjzel tjzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I like it! Let's just tackle a few rough edges and we can ship it.

...components/InteractivePlayground/useEnteringExitingAnimationPlayground/Controls/Controls.tsx Outdated Show resolved Hide resolved
...ents/InteractivePlayground/useEnteringExitingAnimationPlayground/Controls/EasingControls.tsx Outdated Show resolved Hide resolved
...components/InteractivePlayground/useEnteringExitingAnimationPlayground/Controls/Controls.tsx Outdated Show resolved Hide resolved
...components/InteractivePlayground/useEnteringExitingAnimationPlayground/Controls/Controls.tsx Outdated Show resolved Hide resolved
...components/InteractivePlayground/useEnteringExitingAnimationPlayground/Controls/Controls.tsx Show resolved Hide resolved
...nimated/src/components/InteractivePlayground/useEnteringExitingAnimationPlayground/index.tsx Outdated Show resolved Hide resolved
...nimated/src/components/InteractivePlayground/useEnteringExitingAnimationPlayground/index.tsx Outdated Show resolved Hide resolved
@patrycjakalinska patrycjakalinska force-pushed the @patrycjakalinska/entering-exiting-examples branch from 73b2f63 to c74a4a0 Compare September 16, 2024 08:49
@patrycjakalinska patrycjakalinska added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit f76ff9c Sep 20, 2024
8 checks passed
@patrycjakalinska patrycjakalinska deleted the @patrycjakalinska/entering-exiting-examples branch September 20, 2024 05:29
@acoburn acoburn mentioned this pull request Nov 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjzel tjzel tjzel approved these changes

@headfire94 headfire94 headfire94 approved these changes

@szydlovsky szydlovsky Awaiting requested review from szydlovsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrycjakalinska @headfire94 @tjzel