Skip to content

Conversation

@m-bert
Copy link
Contributor

@m-bert m-bert commented Dec 8, 2025

Description

I've noticed that ScrollView did not work on Android. There were two issues with that:

  1. GHScrollView received wrong prop. For some reason linter did not catch that.
  2. RefreshControl was blocking scroll at the top of the list.

This PR changes prop name to the correct one and adds check for scrolling direction so that RefreshControl no longer blocks scrolling.

Test plan

ScrollView and FlatList examples.

@m-bert m-bert marked this pull request as draft December 8, 2025 12:35
@m-bert
Copy link
Contributor Author

m-bert commented Dec 8, 2025

Converted to draft as there's another problem on Android - scroll starts working when pointer is released.

@m-bert m-bert changed the title Pass correct prop to ScrollView [Android] Fix ScrollView Dec 9, 2025
@m-bert m-bert marked this pull request as ready for review December 9, 2025 13:40
@m-bert m-bert merged commit 84550ec into next Dec 9, 2025
5 checks passed
@m-bert m-bert deleted the @mbert/fix-scrolls branch December 9, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants