Fix buttons getting stuck in scroll views during overscroll #3509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-piasecki
force-pushed
the
@jpiasecki/fix-buttons-stuck-in-scroll
branch
from
32a1907 to
68c216b
Compare
m-bert
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses the issue reported in #3350.
Conceptually, it's very similar to the above PR. The main difference is the timing - the above PR cancelled the button during
onReset, while this one addsonFailmethod (analogous toonCancel). This method is called just before the state change, while the timing ofonResetis dependent on the incoming touch stream and handling of other gestures.With this change, I wasn't able to reproduce the issue anymore, though @latekvo mentioned that he was able to get into a situation where none of
onCancel,onFail, andonResetwere called. This would likely manifest in the same way, but it looks like an entirely different problem. Here, the gesture was canceled, while the underlying button was still kept as a touch responder, while in the above situation, the gesture would have never finished (or never activated).Test plan
Tested on the linked reproducer and on the Example app