Add No Shadow rule for eslint #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy this pull request to the software-mansion Team on Vercel. To accomplish this, the commit author's email address needs to be associated with a GitHub account. Learn more about how to change the commit author information. |
kmagiera
approved these changes
Apr 9, 2024
kmagiera
added a commit
that referenced
this pull request
Apr 9, 2024
This PR renames launch configuration properties introduced in #90 It turns out you can use nested objects for launch configuration which looks much better. We are renaming fields like "iOS:scheme" to nested structure `ios: { scheme: "Debug" }}` This PR also fixes issue introduced in #87 where variables used as object keys were renamed in WebviewController.ts
filip131311
added a commit
that referenced
this pull request
Apr 15, 2024
This PR adds so-shadow rule to enlist, in order to prevent bugs during comparison in nested scopes. Additionally this PR back fixes all violations of this rule. --------- Co-authored-by: Filip Andrzej Kaminski <[email protected]>
filip131311
pushed a commit
that referenced
this pull request
Apr 15, 2024
This PR renames launch configuration properties introduced in #90 It turns out you can use nested objects for launch configuration which looks much better. We are renaming fields like "iOS:scheme" to nested structure `ios: { scheme: "Debug" }}` This PR also fixes issue introduced in #87 where variables used as object keys were renamed in WebviewController.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds so-shadow rule to enlist, in order to prevent bugs during comparison in nested scopes.
Additionally this PR back fixes all violations of this rule.