Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable mouse input on a frame. #73

Closed
wants to merge 1 commit into from

Conversation

filip131311
Copy link
Collaborator

This PR make touchHandlers Warp around phone screen instead of the whole phone-content (which includes a frame).
This disables the possibility for a user to interact with the application by clicking on a phone frame.

Fixes: #72

Copy link

vercel bot commented Apr 4, 2024

Someone is attempting to deploy this pull request to the software-mansion Team on Vercel.

To accomplish this, the commit author's email address needs to be associated with a GitHub account.

Learn more about how to change the commit author information.

Copy link
Member

@kmagiera kmagiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done on purpose, such that we can support back-swipe gestures mode easily. Would be better to change it so that there is some margin around the image where we capture the touch instead of allowing the whole to interact.

@filip131311 filip131311 force-pushed the @Filip131311/DisableMouseInputOnAFrame branch from 7601aa9 to fe122d1 Compare April 8, 2024 13:09
@filip131311 filip131311 closed this Apr 8, 2024
@filip131311 filip131311 deleted the @Filip131311/DisableMouseInputOnAFrame branch May 6, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mouse input is captured on the whole phone, including its frame frame.
2 participants