Update iOS builds to use latest iOS SDK #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #587 we updated the way we build iOS apps. We started extracting the SDK from the selected device, and using that for the build. Apparently, the assumption that the installed SDK matches the simulator SDK isn't necessarily correct.
When new SDK is released and xcode is updated, the previous versions of SDK seem to get deleted. This isn't true for simulator runtimes. As a result, simulators can continue to use older runtimes while it is no longer possible for xcodebuild to access these.
In this PR, we are updating iOS build pipeline to use "iphonesimulator" without specifying the exact version. This turns out to be handled well by xcodebuild and allows it to select the most recent, available SDK.
How Has This Been Tested:
xcodebuild -showsdks