Fix stream closing when computer sleeps #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jakub-gonet is attempting to deploy a commit to the software-mansion Team on Vercel. To accomplish this, @jakub-gonet needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
kmagiera
requested changes
Apr 5, 2024
We use <img> tag to display MJPEG stream of simulator frames. It appears that after computer goes to sleep, connection between <img> and simulator server is dropped. This change periodically tries to check if <img> contents is decodable and if not, remounts the image to establish a new connection. Note: there's similar problem with Vite HMR server. It's easier to test this change by using production build. Ref: https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement/decode
jakub-gonet
force-pushed
the
jgonet/sleep
branch
from
8c299e0
to
f57b7e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
<img>tag to display MJPEG stream of simulator frames. It appears that after computer goes to sleep, connection between<img>and simulator server is dropped.This change periodically tries to check if
<img>contents is decodable and if not, remounts the image to establish a new connection.Note: there's similar problem with Vite HMR server. It's easier to test this change by using production build.
Ref: https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement/decode
Fixes #41.