Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block touch and keypress events, hide multitouch indicators in replays #657

Closed
wants to merge 4 commits into from

Conversation

p-malecki
Copy link
Contributor

@p-malecki p-malecki commented Oct 23, 2024

This PR blocks sending of touch and keyboard events and hides multitouch indicators during replays.

Test plan:

  1. Open a replay and attempt to use multitouch. Confirm that multitouch indicators are not visible.
  2. Uncomment the "SIMSERVER_LOG": "debug" flag in the extension's config. Open a replay in the test app, click both inside and outside of the device screen, press any keyboard button and ensure that the logs do not include the "Sending touch" or Sending key" entries.

before:
https://github.com/user-attachments/assets/ba93504a-8008-4b70-9902-ea0f3fb7e2af

after:

Screen.Recording.2024-10-23.at.20.49.27.mov

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radon-ide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 6:49pm

@p-malecki p-malecki changed the title Block seding touch and hide multitouch indicators in replays Block seding touch and keys, hide multitouch indicators in replays Oct 23, 2024
@p-malecki p-malecki changed the title Block seding touch and keys, hide multitouch indicators in replays Block touch and keypress events, hide multitouch indicators in replays Oct 23, 2024
Copy link
Member

@kmagiera kmagiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether there's some better way this can be handled such that we don't add more conditionals to this logic. This seems possible as with replays there's an overlay that should capture events and not pass them down. There's one similar issue I reported #649 and I was hoping we can have some more generic solution that'd allow us to avoid testing agains every other control that can be opened over the screen

@p-malecki
Copy link
Contributor Author

Suggestions have been applied in #685, so I am closing this PR.

@p-malecki p-malecki closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants