fix: Small thumbnails not appearing #1335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pkg.pr.new packages benchmark commit |
reczkok
reviewed
Jun 4, 2025
Comment on lines
85
to
93
| query: 'w=512;1024', | ||
| }) as Record<string, [string, string]>, | ||
| }) as Record<string, string | [string, string]>, | ||
| R.mapKeys(pathToExampleKey), | ||
| R.mapValues((value): ThumbnailPair => ({ | ||
| small: value[0], | ||
| large: value[1], | ||
| })), | ||
| R.mapValues(( | ||
| value, | ||
| ): ThumbnailPair => (typeof value === 'string' | ||
| ? { small: value, large: value } | ||
| : { small: value[0], large: value[1] }) | ||
| ), |
There was a problem hiding this comment.
I would probably prefer having a minimum size requirement for the thumbnail size and throw a descriptive error if it's too small. This would guarantee consistent look for the thumbnails
|
Also, could we change the base to |
aleksanderkatan
force-pushed
the
fix/small-thumbnails-not-appearing
branch
from
47ddb34 to
405238d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To my understanding, the query
w=512;1024only creates two result images if the width of the input image is at least 513, because the only allowed operation by default is downscaling.