Repository navigation
XNNPACK: read inputs with a non-default dim order in their memory layout - #22
Merged
msluszniak merged 1 commit intoOct 22, 2026
Conversation
XNNExecutor reshapes every external input with its sizes listed in dim order, i.e. as the buffer is laid out in memory, but preprocess defined the input from its logical shape. An input recorded with, e.g., dim order (1, 0, 2) (a transposed example input) therefore failed shape propagation with xnn_status_invalid_parameter, or was read with its axes swapped. Define such inputs in memory order and transpose them back to the logical layout at the start of the graph. Channels-last inputs keep going through ChannelsLastTaggedReshapePass. #14735 was the constant-tensor side of this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of pytorch/executorch#24081.