Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for object filters #36

Closed

Conversation

camporter
Copy link
Member

Adds support for object filters by extending the functionality provided by Mask to allow a Property value on the local properties of the Mask.

Service objects are now Filterable, which means they have the ability to set a Filter.

This change is backwards incompatible due to the improvement with the way that masks are created.

@cretz
Copy link
Contributor

cretz commented Sep 6, 2016

LGTM. https://github.com/softlayer/softlayer-java/blob/a6377e9b01b78c9700394c752b1e13457424d29a/README.md#using-object-masks should be updated and a filter-use section should be added. Also, I suggest a version jump to either 0.3.0 (semver says starting w/ 0 means you can make this slight backwards incompat change) or call it good and go with 1.0.0. Also some unit tests targetting the filter stuff specifically is probably warranted.

@allmightyspiff
Copy link
Member

Will merge this as part of #69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants