Skip to content

Conversation

@zoouniak
Copy link
Collaborator

@zoouniak zoouniak commented Feb 25, 2025

📌 작업 내용

  • 답해요 통계 버그 수정

Summary by CodeRabbit

  • New Features

    • Agenda analytics now incorporate institution-specific filtering, delivering more precise monthly, yearly, and category insights.
    • Administrative endpoints have been updated to use user-specific context, ensuring tailored and relevant data views for agenda management.
  • Refactor

    • Data retrieval processes have been streamlined by updating method signatures to embed contextual parameters for improved analytics.

@coderabbitai
Copy link

coderabbitai bot commented Feb 25, 2025

Warning

Rate limit exceeded

@zoouniak has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 27 minutes and 30 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between ede46d7 and ac64920.

📒 Files selected for processing (3)
  • backend/src/main/java/com/bungeobbang/backend/agenda/domain/repository/AgendaRepository.java (2 hunks)
  • backend/src/main/java/com/bungeobbang/backend/agenda/presentation/AdminAgendaController.java (2 hunks)
  • backend/src/main/java/com/bungeobbang/backend/agenda/service/AdminAgendaService.java (2 hunks)

Walkthrough

The changes update methods across the repository, controller, and service layers to include the university context. In the repository, query methods now accept a University parameter and have been renamed accordingly. The controller methods now pass the accessor’s ID (representing the admin) to the service calls. In the service class, methods are modified to receive an admin ID, use it to determine the corresponding university, and perform queries with this additional context. New methods for yearly statistics were also added, and outdated methods without the university filter were removed.

Changes

File(s) Change Summary
backend/src/main/java/com/bungeobbang/backend/agenda/domain/repository/AgendaRepository.java Updated query methods by adding a University parameter and renaming methods (e.g., countByCreatedAtBetween to countByCreatedAtBetweenAndUniversity).
backend/src/main/java/com/bungeobbang/backend/agenda/presentation/AdminAgendaController.java Modified service method calls to include accessor.id() in endpoints for monthly, yearly, and category-based agendas.
backend/src/main/java/com/bungeobbang/backend/agenda/service/AdminAgendaService.java Updated methods to accept a Long id for fetching university context; added new methods for yearly statistics and category counts; removed old implementations lacking university filtering.

Suggested labels

FIX, BE

Suggested reviewers

  • scc9811

Poem

I’m a rabbit hopping in code delight,
Adding filters that keep queries tight.
University context in every call,
Ensuring data is well-filtered for all.
With each method change, the system sings – hop, hop, hoot!
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@zoouniak zoouniak merged commit b48762a into dev Feb 25, 2025
3 of 4 checks passed
@zoouniak zoouniak self-assigned this Feb 25, 2025
@netlify
Copy link

netlify bot commented Feb 25, 2025

Deploy Preview for onu-univ canceled.

Name Link
🔨 Latest commit ac64920
🔍 Latest deploy log https://app.netlify.com/sites/onu-univ/deploys/67bdaff40c484b0008b78e8c

@zoouniak zoouniak added BUG🐛 Something isn't working 🪢BE 백엔드 라벨 labels Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪢BE 백엔드 라벨 BUG🐛 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants