[FIX] 주소 검색어가 없을 때 불필요한 메시지 표시 제거

[young-jin-son]

Issue Number

close #309

As-Is

• 주소 검색어가 비어 있는 상태에서도 검색 결과가 없어요 메시지가 렌더링되어 사용자 경험에 혼란을 줌

To-Be

• 주소 검색어가 비어 있을 경우 검색 결과가 없어요 메시지가 렌더링되지 않도록 조건 분기 추가

Check List

• 테스트가 전부 통과되었나요?
• 모든 commit이 push 되었나요?
• merge할 branch를 확인했나요?
• Assignee를 지정했나요?
• Label을 지정했나요?

Test Screenshot

변경 전	변경 후

(Optional) Additional Description

Summary by CodeRabbit

• New Features
  • Improved search experience by only displaying the "no results" message when the search input is not empty, reducing unnecessary messages when the input field is blank.

[coderabbitai]

Walkthrough

The changes introduce a new boolean prop, isAddressInputEmpty, to the SearchAddressResult component. The component now conditionally displays the "no search results" message only when the address input is not empty and there are no addresses. The parent component passes this new prop based on the input state.

Changes

File(s)	Change Summary
frontend/src/components/SearchAddress/SearchAddressResult/...	Added isAddressInputEmpty prop; changed logic to only show "no results" message if input is not empty.
frontend/src/components/SearchAddress/index.tsx	Passes isAddressInputEmpty prop to child based on whether address input is empty.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SearchAddress
    participant SearchAddressResult

    User->>SearchAddress: Types in address input
    SearchAddress->>SearchAddress: Updates addressInput state
    SearchAddress->>SearchAddressResult: Passes addresses, isAddressInputEmpty
    SearchAddressResult->>SearchAddressResult: Renders results or message based on props

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Do not display "검색 결과가 없어요" message when address input is empty (#309)	✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes found.

Poem

A bunny hopped through code today,
To hide a message right away—
When search is blank, don’t be dismayed,
“No results” quietly stays at bay.
With props and checks, the fix is neat,
The search UI is now complete!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0fb41ca and 5efd20e.

📒 Files selected for processing (2)

• frontend/src/components/SearchAddress/SearchAddressResult/index.tsx (1 hunks)
• frontend/src/components/SearchAddress/index.tsx (1 hunks)

🔇 Additional comments (4)

frontend/src/components/SearchAddress/index.tsx (1)

66-70: LGTM! Clean implementation of the empty input check.

The addition of isAddressInputEmpty={addressInput.length === 0} correctly identifies when the address input is empty and passes this information to the child component. The logic is straightforward and the prop name is descriptive.

frontend/src/components/SearchAddress/SearchAddressResult/index.tsx (3)

9-9: Good addition of the boolean prop for input state tracking.

The new isAddressInputEmpty prop with boolean type is well-defined and supports the conditional rendering logic effectively.

---

12-16: Clean destructuring of the new prop.

The prop is properly destructured and maintains consistency with the existing parameter structure.

---

21-45: Excellent fix for the UX issue - conditional rendering logic is correct.

The updated conditional logic perfectly addresses the PR objective:

• When addresses.length > 0: Shows the address list (unchanged)
• When addresses.length === 0 AND isAddressInputEmpty === true: Shows nothing (prevents unnecessary message)
• When addresses.length === 0 AND isAddressInputEmpty === false: Shows the "No search results" message (existing behavior)

The !isAddressInputEmpty && condition effectively prevents the confusing empty message from appearing when users haven't entered any search terms yet.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.